New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook] Add Electron + Vue cookbook #1681

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@konaraddi

konaraddi commented Jun 11, 2018

Closes #1573 and improves upon #1611

For the Base Example section, I had to deviate from the guidelines a bit to provide enough steps for the reader to follow. Please let me know if and what changes need to be made. Thanks!

@sdras sdras added the cookbook label Jun 17, 2018

@sdras

This comment has been minimized.

Member

sdras commented Jun 17, 2018

Thanks! I'll take a look soon

@konaraddi

This comment has been minimized.

konaraddi commented Sep 11, 2018

Hi @sdras , would you be able to review the cookbook? If not, no worries (I totally understand if you're time is better spent elsewhere!)

@sdras

This comment has been minimized.

Member

sdras commented Sep 11, 2018

I know you've waited a bit and apologize on the delay! but I'm still on honeymoon until later this week. I will get back to you next week at the latest. Thanks for the ping.

@konaraddi

This comment has been minimized.

konaraddi commented Sep 11, 2018

Thanks! Enjoy your honeymoon!

@sdras

This comment has been minimized.

Member

sdras commented Sep 20, 2018

Hi there @konaraddi! I'm back.

So, this is incredibly promising and well written. I think it will be a great addition. However, the Vue CLI was upgraded a little bit ago- I tested it out and this version is only compatible with the older version of the CLI, not 3. Could you please work on it so that it will work with that version? https://cli.vuejs.org/

Once that is done, I'll give it a more thorough review. Thanks for your work on it!

@@ -2,7 +2,7 @@
"name": "vuejs.org",
"private": true,
"hexo": {
"version": "3.7.0"
"version": "3.7.1"

This comment has been minimized.

@phanan

phanan Sep 20, 2018

Member

Is this change necessary for the PR?

This comment has been minimized.

@konaraddi

konaraddi Nov 2, 2018

Oops, I bumped it back down in 28d53af. I don't remember specifically wanting to bump up the version of hexo (I haven't use hexo elsewhere); might be from running npm install. Anyways, I'll be sure to commit only the necessary files next time. Thanks!

</template>
<script>
export default {

This comment has been minimized.

@phanan

phanan Sep 20, 2018

Member

IMHO this code example is a bit too long, which makes it harder for 1) readers to follow and 2) maintainers to sync between the markdown and the raw scripts. Can we use something shorter e.g. (OTOMH) the todo app?

This comment has been minimized.

@konaraddi

konaraddi Nov 2, 2018

I considered the todo app but went with the timer because building a timer

  • is quick to build and easy to understand what the code is doing
  • is a small amount of code (and less code than results for todo lists built with Vue on GitHub)

A timer lets us focus on the Electron part of the cookbook. I think with a todo list I'd be spending most of the tutorial on how to build a todo list in Vue, and many existing tutorials for Vue involve building todo lists.

This comment has been minimized.

@phanan

phanan Nov 14, 2018

Member

I still maintain that the current code is too long for a cookbook. I personally find it hard to follow, and would like to think that defeats the purpose.
Btw (and I missed this before), it would be far better IMHO if we don't need to rely on a third party boilerplate (simulatedgreg/electron-vue) for this.

@konaraddi

This comment has been minimized.

konaraddi commented Nov 2, 2018

Should I copy and paste the package-lock.json from vuejs/vuejs.org to konaraddi/vuejs.org to fix the conflict?

@konaraddi

This comment has been minimized.

konaraddi commented Nov 13, 2018

@sdras @phanan I updated the cookbook for Vue CLI 3, can you have a look whenever you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment