Changing repo label depending on the host

[ycmjason]

Fixing #167

[inosik]

Maybe this should be configurable?

[ycmjason]

maybe I will keep the logic now since it is quite nice to have less config. But with the config would be a fallback? would that make sense?

[inosik]

I'd just keep it simple and let the user configure it with a repoLabel option. But maybe it's just me 😄

[ycmjason]

I personally prefer just setting therepoLink then everything else works. Instead of having needed to set the repoLabel. Let me just quickly add this. We can wait for more opinions.

[ycmjason]

@inosik added the repoLabel option. I have kept the auto generated "GitHub", "GitLab", "Bitbucket" when repoLabel is not defined.

[ulivz]

In client side you shouldn't use includes and find since Buble doesn't ployfill for that.

BTW, why define a Uppercase constant and then toLowerCase?

[ycmjason]

Oh okay, I would change this to match instead.

Defining uppercase constants since they are what we want to show on the header, lowercase since we want to compare. But actually using regex with case insensitive flag and match would be nicer.

[ulivz]

Since repo link start with https://, so the check match(/^https?:\/\/[^/]+/)[0] is duplicated.

in other words, the statements match(/^https?:\/\/[^/]+/)[0] is dangerous since match would return undefined!

[ycmjason]

This is true. Will fix this later.

[ulivz]

Why adding this?

[ycmjason]

For vim swap files.

[ulivz]

You should add it at your project instead of here.

[ycmjason]

Just thought it would be great since there might be other contributors who use vim.

[ulivz]

Hmmm, so should I put all the different needs here?

[ycmjason]

It's up to you guys. I could remove it if you don't like it.

I just feel that it's not something that will hurt to add and might make other vim contributors lives easier. If there are other contributors who uses other editors which has some other ignore files, I couldn't see why we shouldn't facilitate it.

[ulivz]

It doesn't depend on me. please do not kidnap thinking.

What I want to say it that you can set this to a global git configuration instead of duplicating it everywhere.

[ycmjason]

That is certainly not true for me. I am happy to remove that if this is not wanted.

[ulivz]

Looks less stable, please test more. Thanks!

[ycmjason]

@ulivz I have made some changes. Please review them again.

Here are some changes:

• Added a guarded clause to avoid this.repoLink.match from failing since we could be confident that this.repoLink will always start with https://.
• Used for-loop to achieve the same functionality of Array.prototype.find.
• Used RegExp.prototype.test to check if the host of the repoLink contains any recognised platform, if not return "Source".

[ulivz]

Hmmmm.... this commit introduced a very obvious bug:

Fixed at f55fa00.