New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing repo label depending on the host #168

Merged
merged 6 commits into from Apr 20, 2018

Conversation

Projects
None yet
4 participants
@ycmjason
Copy link
Contributor

ycmjason commented Apr 20, 2018

Fixing #167

@ycmjason ycmjason force-pushed the ycmjason:fix-github-link-label branch from 24ea10f to fcb0042 Apr 20, 2018

@ycmjason ycmjason force-pushed the ycmjason:fix-github-link-label branch from fcb0042 to c5a8f58 Apr 20, 2018

@ycmjason ycmjason force-pushed the ycmjason:fix-github-link-label branch from c5a8f58 to 34ccc58 Apr 20, 2018

@inosik

This comment has been minimized.

Copy link

inosik commented Apr 20, 2018

Maybe this should be configurable?

@ycmjason

This comment has been minimized.

Copy link
Contributor

ycmjason commented Apr 20, 2018

maybe I will keep the logic now since it is quite nice to have less config. But with the config would be a fallback? would that make sense?

@inosik

This comment has been minimized.

Copy link

inosik commented Apr 20, 2018

I'd just keep it simple and let the user configure it with a repoLabel option. But maybe it's just me 😄

@ycmjason

This comment has been minimized.

Copy link
Contributor

ycmjason commented Apr 20, 2018

I personally prefer just setting therepoLink then everything else works. Instead of having needed to set the repoLabel. Let me just quickly add this. We can wait for more opinions.

@ycmjason

This comment has been minimized.

Copy link
Contributor

ycmjason commented Apr 20, 2018

@inosik added the repoLabel option. I have kept the auto generated "GitHub", "GitLab", "Bitbucket" when repoLabel is not defined.

@ycmjason ycmjason force-pushed the ycmjason:fix-github-link-label branch from fa8eee9 to bbec29f Apr 20, 2018

@ycmjason ycmjason force-pushed the ycmjason:fix-github-link-label branch from bbec29f to bb33ae3 Apr 20, 2018

const repoHost = this.repoLink.match(/^https?:\/\/[^/]+/)[0] || 'github'
return ['GitHub', 'GitLab', 'Bitbucket'].find(platform => {
return repoHost.toLowerCase().includes(platform.toLowerCase())

This comment has been minimized.

@ulivz

ulivz Apr 20, 2018

Member

In client side you shouldn't use includes and find since Buble doesn't ployfill for that.

BTW, why define a Uppercase constant and then toLowerCase?

This comment has been minimized.

@ycmjason

ycmjason Apr 20, 2018

Contributor

Oh okay, I would change this to match instead.

Defining uppercase constants since they are what we want to show on the header, lowercase since we want to compare. But actually using regex with case insensitive flag and match would be nicer.

repoLabel () {
if (this.$site.themeConfig.repoLabel) return this.$site.themeConfig.repoLabel
const repoHost = this.repoLink.match(/^https?:\/\/[^/]+/)[0] || 'github'

This comment has been minimized.

@ulivz

ulivz Apr 20, 2018

Member

Since repo link start with https://, so the check match(/^https?:\/\/[^/]+/)[0] is duplicated.

in other words, the statements match(/^https?:\/\/[^/]+/)[0] is dangerous since match would return undefined!

This comment has been minimized.

@ycmjason

ycmjason Apr 20, 2018

Contributor

This is true. Will fix this later.

.gitignore Outdated
@@ -4,3 +4,4 @@ node_modules
.temp
vuepress
TODOs.md
*.sw*

This comment has been minimized.

@ulivz

ulivz Apr 20, 2018

Member

Why adding this?

This comment has been minimized.

@ycmjason

ycmjason Apr 20, 2018

Contributor

For vim swap files.

This comment has been minimized.

@ulivz

ulivz Apr 20, 2018

Member

You should add it at your project instead of here.

This comment has been minimized.

@ycmjason

ycmjason Apr 20, 2018

Contributor

Just thought it would be great since there might be other contributors who use vim.

This comment has been minimized.

@ulivz

ulivz Apr 20, 2018

Member

Hmmm, so should I put all the different needs here?

This comment has been minimized.

@ycmjason

ycmjason Apr 20, 2018

Contributor

It's up to you guys. I could remove it if you don't like it.

I just feel that it's not something that will hurt to add and might make other vim contributors lives easier. If there are other contributors who uses other editors which has some other ignore files, I couldn't see why we shouldn't facilitate it.

This comment has been minimized.

@ulivz

ulivz Apr 20, 2018

Member

It doesn't depend on me. please do not kidnap thinking.

What I want to say it that you can set this to a global git configuration instead of duplicating it everywhere.

This comment has been minimized.

@ycmjason

ycmjason Apr 20, 2018

Contributor

That is certainly not true for me. I am happy to remove that if this is not wanted.

@ulivz
Copy link
Member

ulivz left a comment

Looks less stable, please test more. Thanks!

@ycmjason

This comment has been minimized.

Copy link
Contributor

ycmjason commented Apr 20, 2018

@ulivz I have made some changes. Please review them again.

Here are some changes:

  • Added a guarded clause to avoid this.repoLink.match from failing since we could be confident that this.repoLink will always start with https://.
  • Used for-loop to achieve the same functionality of Array.prototype.find.
  • Used RegExp.prototype.test to check if the host of the repoLink contains any recognised platform, if not return "Source".

yyx990803 added some commits Apr 20, 2018

@yyx990803 yyx990803 merged commit c1bbd05 into vuejs:master Apr 20, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details
@ulivz

This comment has been minimized.

Copy link
Member

ulivz commented Apr 21, 2018

Hmmmm.... this commit introduced a very obvious bug:

image

Fixed at f55fa00.

@ycmjason ycmjason deleted the ycmjason:fix-github-link-label branch Apr 21, 2018

LinFeng1997 added a commit to docschina/vuepress that referenced this pull request Apr 28, 2018

update master (#14)
* refactor: avoid iterator

* tweak: navbar styles

* chore: issue template

* docs: added reference to emoji list (vuejs#148)

* tweak: fix padding for highlighted line (vuejs#149)

* docs(zh-CN): fix typo (vuejs#152)

* tweak: ensure that all the dropdown's style are consistent (vuejs#156)

* chore: tweak issue template

* fix: show navbar in more conditions (close vuejs#170)

* fix: redirect /foo to /foo/ during dev (close vuejs#183)

* fix: infer source link label from repo url (vuejs#168)

* docs: improved instructions on github deployment (vuejs#173)

* fix: prioritize frontmatter's title, description and lang (vuejs#180)

close vuejs#177 close vuejs#184

* fix: Only add language dropdown when there has more than one locale configured. (vuejs#181)

* 0.7.1

* chore: changelog

* fix: Fix the style of repo link.

* fix margin

* docs: Update Multi-Language Support (vuejs#192)

* chore: unexpected `background-color` value from code block (vuejs#217)

* feat: support toml config (vuejs#138)

* feat: support toml config

* remove config.toml

* fix: proper iteration over meta tags

* feat: support built-in pug config and document using pro-processors at component (vuejs#151)

* feat: theme index enhancment support (vuejs#154)

* feat: Add docsRepo (vuejs#155)

* feat: expose all css pre-processor's options. (close vuejs#169) (vuejs#178)

* docs: clarify documentation on how to use links (vuejs#188)

* docs(multiple sidebars): clarify documentation (vuejs#190)

* docs: add example for nested custom components (vuejs#195)

* feat: support for TOML front matter (vuejs#141) (vuejs#164)

* feat: add max search suggestions config (vuejs#163)

* fix: fix emoji not showing on sidebars (vuejs#206)

* fix: fix Sidebar link active logic (vuejs#215)

* refactor: remove unnecessary method

* fix: fix title inferrence regression (close vuejs#208)

* fix: siteTitle vs pageTitle

* feat: support excerpt extraction with `<!-- more -->` (close vuejs#174)

* docs: tweak deploy guide

* fix: default to localhost on windows (close vuejs#221)

* docs: add deploy guide for firebase (vuejs#213)

* docs: add deploy guide for GitLab pages + GitLab CI (vuejs#219)

* tweak: improve mobile UX for sidebar links (vuejs#212)

* docs: add .vuepress/override.styl reference (vuejs#224)

* feat: Algolia DocSearch Integration  (vuejs#201)

* refactor: load theme/enhanceApp.js instead of index.js

* feat: also expose siteData in enhanceApp.js

* fix: renames index.js to enhanceApp.js (vuejs#226)

* docs: new content for new feautures

* fix: algolia check should be checking themeConfig.algolia

* docs: more updates

* docs(cn): add section for custom page class

* 0.8.0

* chore: changelog

* fix: algolia regression (close vuejs#228)

* 0.8.1

* chore: changelog

* fix: nav-item underline use $accentColor (vuejs#230)

* feat: expose layout slots for injecting custom content

* docs: use extended theme

* tweak: use lighter underline

* 0.8.2

* chore: changelog

* chore: vuepress-theme-vue should be a dev dep

* fix: always write override.style

* 0.8.3

* chore: changelog

* feat: support disable navbar via front matter (close: vuejs#187) (vuejs#232)

* docs: update for disabling navbar via front matter (vuejs#232)

* doc: correct file extension (vuejs#236)

* fix: algolia regression - missing options (close vuejs#234)

* 0.8.4

* chore: changelog

* refactor: use css-loader/locals in ssr bundle

* tweak: add home link on 404 page

* tweak: cursor on search box should be text (vuejs#244)

* fix: avoid the searchbox exceeded out of screen in narrow screen (vuejs#254)

* tweak: add cursor pointer in li (vuejs#247)

* fix: potential duplicate iteration keys at dropdown (vuejs#249)

* update README-en.md

LinFeng1997 added a commit to docschina/vuepress that referenced this pull request May 25, 2018

v0.9.0 Translation (#16)
* refactor: avoid iterator

* tweak: navbar styles

* chore: issue template

* docs: added reference to emoji list (vuejs#148)

* tweak: fix padding for highlighted line (vuejs#149)

* docs(zh-CN): fix typo (vuejs#152)

* tweak: ensure that all the dropdown's style are consistent (vuejs#156)

* chore: tweak issue template

* fix: show navbar in more conditions (close vuejs#170)

* fix: redirect /foo to /foo/ during dev (close vuejs#183)

* fix: infer source link label from repo url (vuejs#168)

* docs: improved instructions on github deployment (vuejs#173)

* fix: prioritize frontmatter's title, description and lang (vuejs#180)

close vuejs#177 close vuejs#184

* fix: Only add language dropdown when there has more than one locale configured. (vuejs#181)

* 0.7.1

* chore: changelog

* fix: Fix the style of repo link.

* fix margin

* docs: Update Multi-Language Support (vuejs#192)

* chore: unexpected `background-color` value from code block (vuejs#217)

* feat: support toml config (vuejs#138)

* feat: support toml config

* remove config.toml

* fix: proper iteration over meta tags

* feat: support built-in pug config and document using pro-processors at component (vuejs#151)

* feat: theme index enhancment support (vuejs#154)

* feat: Add docsRepo (vuejs#155)

* feat: expose all css pre-processor's options. (close vuejs#169) (vuejs#178)

* docs: clarify documentation on how to use links (vuejs#188)

* docs(multiple sidebars): clarify documentation (vuejs#190)

* docs: add example for nested custom components (vuejs#195)

* feat: support for TOML front matter (vuejs#141) (vuejs#164)

* feat: add max search suggestions config (vuejs#163)

* fix: fix emoji not showing on sidebars (vuejs#206)

* fix: fix Sidebar link active logic (vuejs#215)

* refactor: remove unnecessary method

* fix: fix title inferrence regression (close vuejs#208)

* fix: siteTitle vs pageTitle

* feat: support excerpt extraction with `<!-- more -->` (close vuejs#174)

* docs: tweak deploy guide

* fix: default to localhost on windows (close vuejs#221)

* docs: add deploy guide for firebase (vuejs#213)

* docs: add deploy guide for GitLab pages + GitLab CI (vuejs#219)

* tweak: improve mobile UX for sidebar links (vuejs#212)

* docs: add .vuepress/override.styl reference (vuejs#224)

* feat: Algolia DocSearch Integration  (vuejs#201)

* refactor: load theme/enhanceApp.js instead of index.js

* feat: also expose siteData in enhanceApp.js

* fix: renames index.js to enhanceApp.js (vuejs#226)

* docs: new content for new feautures

* fix: algolia check should be checking themeConfig.algolia

* docs: more updates

* docs(cn): add section for custom page class

* 0.8.0

* chore: changelog

* fix: algolia regression (close vuejs#228)

* 0.8.1

* chore: changelog

* fix: nav-item underline use $accentColor (vuejs#230)

* feat: expose layout slots for injecting custom content

* docs: use extended theme

* tweak: use lighter underline

* 0.8.2

* chore: changelog

* chore: vuepress-theme-vue should be a dev dep

* fix: always write override.style

* 0.8.3

* chore: changelog

* feat: support disable navbar via front matter (close: vuejs#187) (vuejs#232)

* docs: update for disabling navbar via front matter (vuejs#232)

* doc: correct file extension (vuejs#236)

* fix: algolia regression - missing options (close vuejs#234)

* 0.8.4

* chore: changelog

* refactor: use css-loader/locals in ssr bundle

* tweak: add home link on 404 page

* tweak: cursor on search box should be text (vuejs#244)

* fix: avoid the searchbox exceeded out of screen in narrow screen (vuejs#254)

* tweak: add cursor pointer in li (vuejs#247)

* fix: potential duplicate iteration keys at dropdown (vuejs#249)

* feat: support disable navbar globally (vuejs#246)

* docs: update doc for disabling navbar globally (vuejs#246)

* docs: update Chinese translation for deploying.

* docs: add a tip for built-in search and fix typo (vuejs#262)

* docs(cn): add tip for built-in search (vuejs#262)

* chore: lint code (vuejs#264)

* workflow: upgrade eslint-plugin-vue-libs

* refactor: move noopModule

* docs: add note about gitbook

* docs: Gitbook -> GitBook

* chore: bump theme

* docs(cn): fix typo (vuejs#275)

* feat: highlight current region in sidebar (vuejs#272)

* chore: update yarn.lock

* fix: relative link checking

* fix: ensure `<script>` blocks in SFCs in node_modules are transpiled

* feat: hide edit link by page (close: vuejs#284) (vuejs#286)

* docs(cn): update doc for hiding edit link by page (vuejs#286)

* feat: header extraction improvement (close: vuejs#238) (vuejs#271)

* feat: sidebar header extraction improvements (close: vuejs#238)

* chore: add more markdown tokens to be removed

* fix: typo

* chore: show warnings in build debug mode (vuejs#285)

* chore: remove colon in stylus of NavLinks (vuejs#299)

* docs: add missing < (vuejs#302)

* docs(cn): add missing <

* fix: title cannot be number at front matter (vuejs#297)

* fix: unexpected scroll behavior after clicking sidebar links (vuejs#298)

* docs(cn): tweaks (vuejs#312)

* fix: index file judgement bug (close: vuejs#306) (vuejs#308)

* chore: log error when set outDir to cwd (close: vuejs#322) (vuejs#324)

* feat: handle telephone links (vuejs#325)

* refactor: avoid using regexp's lookbehind (vuejs#323)

* docs: link LICENSE (vuejs#328)

* fix: unexpected top blank space when navbar is disable (vuejs#316)

* docs: link some items at README

* docs: fix typo (vuejs#333)

* docs: use explicit link for LICENSE

* docs: add some shields badges to README

* docs: use rawgit logo to make it display at npm page.

* refactor: make the prepare process clearer and modify the resolve alias (vuejs#277)

* feat: generate the timestamp of last updated for each doc (close vuejs#258) (vuejs#282)

* fix: code looks not good at small sreen (close: vuejs#350)

* feat: make code type insensitive (close: vuejs#347)

* docs: add surge deploy instructions (vuejs#352)

* docs(cn): add surge deploy instructions (vuejs#352)

* feat: support global markdown config for attributes of external links (vuejs#358)

* docs(cn): support global md config for attributes of external links (vuejs#358)

* fix: duplicate slash when docs dir is not set (vuejs#361)

* fix: dropdown overlap due to word wrapping (close: vuejs#359) (vuejs#360)

* feat: last updated UI in default theme. (vuejs#338)

* docs: tweaks themeConfig.editLinks (vuejs#378)

* docs(cn): tweaks themeConfig.editLinks (vuejs#378)

* fix: image overflow at custom content (close: vuejs#381) (vuejs#383)

* fix: postcss-loader warnings (close: vuejs#278)

* feat: using babel and support JSX in vue. (close: vuejs#318) (vuejs#336)

* docs: add heroku deploy instructions (vuejs#366)

* chore: update yarn.lock

* fix: $page is missing at 404 page (vuejs#388)

* fix: resolve custom theme from global cli (close: vuejs#392) (vuejs#399)

* feat: bump up webpack to 4.8.1 (close: vuejs#309)

* docs(cn): add heroku deploy instructions (vuejs#366)

* docs(cn): tweaks service worker (vuejs#406)

* fix: remove style override limitation to custom theme (close: 404) (vuejs#405)

* docs: add some links (vuejs#403)

* fix: glob patterns error on windows (close: vuejs#348) (vuejs#400)

* docs(cn): add links

* fix: missing title and desc in 404 and custom theme.

* chore: tweaks

* Revert "fix: code looks not good at small sreen (close: vuejs#350)"

This reverts commit 6514c8f.

* fix: code looks not good at small sreen (close: vuejs#350)

* chore: fix typo

* refactor: root mixins injection (vuejs#423)

* docs: tweaks (vuejs#422)

* fix: emoji doesn't work in toc (close: vuejs#417) (vuejs#418)

* refactor: hoist pre wrapper as a standalone plugin.

* refactor(babel-loader): resolve absolute module paths (vuejs#436)

* chore: fix typo in home styling (vuejs#435)

* chore: add language ts support (vuejs#431)

* chore: allow class and style merging for content (vuejs#430)

* docs: fix links typo (vuejs#427)

* fix: highlight line issue for empty lines

* fix: highlight lines are cut when sliding (vuejs#437)

* fix: upgrade webpack-serve and avoid port conflict (close vuejs#424) (vuejs#425)

* fix: use v-for with key (vuejs#438)

* feat: show OutboundLink icon for external links (vuejs#428)

* docs: tweaks quote syntax (vuejs#440)

* docs(cn): tweaks quote syntax (vuejs#440)

* docs: avoid indent in code block

* feat: code line numbers (close: vuejs#365) (vuejs#379)

* refactor: use stylus iteration to generate the lang tip

* fix: nav link highlight issue with i18n (close: vuejs#445)

* feat: support style lang postcss (close: vuejs#461)

* feat: support render $page.excerpt to HTML (close: vuejs#458)

* chore: fix typo

* fix: missing css source map at dev environment (vuejs#460)

* chore: tweaks yarn.lock

* chore: upgrade dependencies to make it work at node 10. (vuejs#456)

* fix: highlight active link (vuejs#272) doesn't work with non-EN hash.

* docs: fix typo (vuejs#467)

* docs: fix typo (vuejs#466)

* fix: unexpected warning when using non-ASCII chars as filename.

* chore: fix a stylus syntax error (vuejs#474)

* doc: update for changing config of markdown-it (vuejs#477)

* docs(cn): update for changing config of markdown-it (vuejs#477)

* refactor: move loadConfig into util

* perf: vastly improve rebuild perf with caching

* workflow: use cc cli

* 0.9.0

* Translate config for v0.9.0

LinFeng1997 added a commit to docschina/vuepress that referenced this pull request May 27, 2018

Translate to v0.10.0 (#17)
* refactor: avoid iterator

* tweak: navbar styles

* chore: issue template

* docs: added reference to emoji list (vuejs#148)

* tweak: fix padding for highlighted line (vuejs#149)

* docs(zh-CN): fix typo (vuejs#152)

* tweak: ensure that all the dropdown's style are consistent (vuejs#156)

* chore: tweak issue template

* fix: show navbar in more conditions (close vuejs#170)

* fix: redirect /foo to /foo/ during dev (close vuejs#183)

* fix: infer source link label from repo url (vuejs#168)

* docs: improved instructions on github deployment (vuejs#173)

* fix: prioritize frontmatter's title, description and lang (vuejs#180)

close vuejs#177 close vuejs#184

* fix: Only add language dropdown when there has more than one locale configured. (vuejs#181)

* 0.7.1

* chore: changelog

* fix: Fix the style of repo link.

* fix margin

* docs: Update Multi-Language Support (vuejs#192)

* chore: unexpected `background-color` value from code block (vuejs#217)

* feat: support toml config (vuejs#138)

* feat: support toml config

* remove config.toml

* fix: proper iteration over meta tags

* feat: support built-in pug config and document using pro-processors at component (vuejs#151)

* feat: theme index enhancment support (vuejs#154)

* feat: Add docsRepo (vuejs#155)

* feat: expose all css pre-processor's options. (close vuejs#169) (vuejs#178)

* docs: clarify documentation on how to use links (vuejs#188)

* docs(multiple sidebars): clarify documentation (vuejs#190)

* docs: add example for nested custom components (vuejs#195)

* feat: support for TOML front matter (vuejs#141) (vuejs#164)

* feat: add max search suggestions config (vuejs#163)

* fix: fix emoji not showing on sidebars (vuejs#206)

* fix: fix Sidebar link active logic (vuejs#215)

* refactor: remove unnecessary method

* fix: fix title inferrence regression (close vuejs#208)

* fix: siteTitle vs pageTitle

* feat: support excerpt extraction with `<!-- more -->` (close vuejs#174)

* docs: tweak deploy guide

* fix: default to localhost on windows (close vuejs#221)

* docs: add deploy guide for firebase (vuejs#213)

* docs: add deploy guide for GitLab pages + GitLab CI (vuejs#219)

* tweak: improve mobile UX for sidebar links (vuejs#212)

* docs: add .vuepress/override.styl reference (vuejs#224)

* feat: Algolia DocSearch Integration  (vuejs#201)

* refactor: load theme/enhanceApp.js instead of index.js

* feat: also expose siteData in enhanceApp.js

* fix: renames index.js to enhanceApp.js (vuejs#226)

* docs: new content for new feautures

* fix: algolia check should be checking themeConfig.algolia

* docs: more updates

* docs(cn): add section for custom page class

* 0.8.0

* chore: changelog

* fix: algolia regression (close vuejs#228)

* 0.8.1

* chore: changelog

* fix: nav-item underline use $accentColor (vuejs#230)

* feat: expose layout slots for injecting custom content

* docs: use extended theme

* tweak: use lighter underline

* 0.8.2

* chore: changelog

* chore: vuepress-theme-vue should be a dev dep

* fix: always write override.style

* 0.8.3

* chore: changelog

* feat: support disable navbar via front matter (close: vuejs#187) (vuejs#232)

* docs: update for disabling navbar via front matter (vuejs#232)

* doc: correct file extension (vuejs#236)

* fix: algolia regression - missing options (close vuejs#234)

* 0.8.4

* chore: changelog

* refactor: use css-loader/locals in ssr bundle

* tweak: add home link on 404 page

* tweak: cursor on search box should be text (vuejs#244)

* fix: avoid the searchbox exceeded out of screen in narrow screen (vuejs#254)

* tweak: add cursor pointer in li (vuejs#247)

* fix: potential duplicate iteration keys at dropdown (vuejs#249)

* feat: support disable navbar globally (vuejs#246)

* docs: update doc for disabling navbar globally (vuejs#246)

* docs: update Chinese translation for deploying.

* docs: add a tip for built-in search and fix typo (vuejs#262)

* docs(cn): add tip for built-in search (vuejs#262)

* chore: lint code (vuejs#264)

* workflow: upgrade eslint-plugin-vue-libs

* refactor: move noopModule

* docs: add note about gitbook

* docs: Gitbook -> GitBook

* chore: bump theme

* docs(cn): fix typo (vuejs#275)

* feat: highlight current region in sidebar (vuejs#272)

* chore: update yarn.lock

* fix: relative link checking

* fix: ensure `<script>` blocks in SFCs in node_modules are transpiled

* feat: hide edit link by page (close: vuejs#284) (vuejs#286)

* docs(cn): update doc for hiding edit link by page (vuejs#286)

* feat: header extraction improvement (close: vuejs#238) (vuejs#271)

* feat: sidebar header extraction improvements (close: vuejs#238)

* chore: add more markdown tokens to be removed

* fix: typo

* chore: show warnings in build debug mode (vuejs#285)

* chore: remove colon in stylus of NavLinks (vuejs#299)

* docs: add missing < (vuejs#302)

* docs(cn): add missing <

* fix: title cannot be number at front matter (vuejs#297)

* fix: unexpected scroll behavior after clicking sidebar links (vuejs#298)

* docs(cn): tweaks (vuejs#312)

* fix: index file judgement bug (close: vuejs#306) (vuejs#308)

* chore: log error when set outDir to cwd (close: vuejs#322) (vuejs#324)

* feat: handle telephone links (vuejs#325)

* refactor: avoid using regexp's lookbehind (vuejs#323)

* docs: link LICENSE (vuejs#328)

* fix: unexpected top blank space when navbar is disable (vuejs#316)

* docs: link some items at README

* docs: fix typo (vuejs#333)

* docs: use explicit link for LICENSE

* docs: add some shields badges to README

* docs: use rawgit logo to make it display at npm page.

* refactor: make the prepare process clearer and modify the resolve alias (vuejs#277)

* feat: generate the timestamp of last updated for each doc (close vuejs#258) (vuejs#282)

* fix: code looks not good at small sreen (close: vuejs#350)

* feat: make code type insensitive (close: vuejs#347)

* docs: add surge deploy instructions (vuejs#352)

* docs(cn): add surge deploy instructions (vuejs#352)

* feat: support global markdown config for attributes of external links (vuejs#358)

* docs(cn): support global md config for attributes of external links (vuejs#358)

* fix: duplicate slash when docs dir is not set (vuejs#361)

* fix: dropdown overlap due to word wrapping (close: vuejs#359) (vuejs#360)

* feat: last updated UI in default theme. (vuejs#338)

* docs: tweaks themeConfig.editLinks (vuejs#378)

* docs(cn): tweaks themeConfig.editLinks (vuejs#378)

* fix: image overflow at custom content (close: vuejs#381) (vuejs#383)

* fix: postcss-loader warnings (close: vuejs#278)

* feat: using babel and support JSX in vue. (close: vuejs#318) (vuejs#336)

* docs: add heroku deploy instructions (vuejs#366)

* chore: update yarn.lock

* fix: $page is missing at 404 page (vuejs#388)

* fix: resolve custom theme from global cli (close: vuejs#392) (vuejs#399)

* feat: bump up webpack to 4.8.1 (close: vuejs#309)

* docs(cn): add heroku deploy instructions (vuejs#366)

* docs(cn): tweaks service worker (vuejs#406)

* fix: remove style override limitation to custom theme (close: 404) (vuejs#405)

* docs: add some links (vuejs#403)

* fix: glob patterns error on windows (close: vuejs#348) (vuejs#400)

* docs(cn): add links

* fix: missing title and desc in 404 and custom theme.

* chore: tweaks

* Revert "fix: code looks not good at small sreen (close: vuejs#350)"

This reverts commit 6514c8f.

* fix: code looks not good at small sreen (close: vuejs#350)

* chore: fix typo

* refactor: root mixins injection (vuejs#423)

* docs: tweaks (vuejs#422)

* fix: emoji doesn't work in toc (close: vuejs#417) (vuejs#418)

* refactor: hoist pre wrapper as a standalone plugin.

* refactor(babel-loader): resolve absolute module paths (vuejs#436)

* chore: fix typo in home styling (vuejs#435)

* chore: add language ts support (vuejs#431)

* chore: allow class and style merging for content (vuejs#430)

* docs: fix links typo (vuejs#427)

* fix: highlight line issue for empty lines

* fix: highlight lines are cut when sliding (vuejs#437)

* fix: upgrade webpack-serve and avoid port conflict (close vuejs#424) (vuejs#425)

* fix: use v-for with key (vuejs#438)

* feat: show OutboundLink icon for external links (vuejs#428)

* docs: tweaks quote syntax (vuejs#440)

* docs(cn): tweaks quote syntax (vuejs#440)

* docs: avoid indent in code block

* feat: code line numbers (close: vuejs#365) (vuejs#379)

* refactor: use stylus iteration to generate the lang tip

* fix: nav link highlight issue with i18n (close: vuejs#445)

* feat: support style lang postcss (close: vuejs#461)

* feat: support render $page.excerpt to HTML (close: vuejs#458)

* chore: fix typo

* fix: missing css source map at dev environment (vuejs#460)

* chore: tweaks yarn.lock

* chore: upgrade dependencies to make it work at node 10. (vuejs#456)

* fix: highlight active link (vuejs#272) doesn't work with non-EN hash.

* docs: fix typo (vuejs#467)

* docs: fix typo (vuejs#466)

* fix: unexpected warning when using non-ASCII chars as filename.

* chore: fix a stylus syntax error (vuejs#474)

* doc: update for changing config of markdown-it (vuejs#477)

* docs(cn): update for changing config of markdown-it (vuejs#477)

* refactor: move loadConfig into util

* perf: vastly improve rebuild perf with caching

* workflow: use cc cli

* 0.9.0

* chore: changelog

* workflow: update issue templates

* workflow: add pull request template

* workflow: update issue template

* feat: allow for disabling of active hash on scroll (vuejs#489)

* refactor: load 'active header links' on demand

* docs: update docs for 'active header links'

* chore: remove console

* workflow: update pull request template

* feat: support filename that contains non-ASCII and unicode chars (vuejs#473)

* docs: tweaks active header links

* refactor: unify style of function.

* fix: lastUpdated looks bad when editLinks is false.

* fix: wrong OutboundLink insertion position (close: vuejs#496)

* docs: fix typo (vuejs#498)

* Translate config for v0.9.0

* fix: avoid cache error (close vuejs#492)

* fix: fix config reload cache busting

* 0.9.1

* chore: changelog

* feat: upgrade to babel 7 + use @vue/babel-preset-app

* 0.10.0

* chore: changelog

* feat: better log (vuejs#506)

* Translate config for v0.10.0

LinFeng1997 added a commit to docschina/vuepress that referenced this pull request Jul 14, 2018

Translate to v0.12.0 (#18)
* refactor: avoid iterator

* tweak: navbar styles

* chore: issue template

* docs: added reference to emoji list (vuejs#148)

* tweak: fix padding for highlighted line (vuejs#149)

* docs(zh-CN): fix typo (vuejs#152)

* tweak: ensure that all the dropdown's style are consistent (vuejs#156)

* chore: tweak issue template

* fix: show navbar in more conditions (close vuejs#170)

* fix: redirect /foo to /foo/ during dev (close vuejs#183)

* fix: infer source link label from repo url (vuejs#168)

* docs: improved instructions on github deployment (vuejs#173)

* fix: prioritize frontmatter's title, description and lang (vuejs#180)

close vuejs#177 close vuejs#184

* fix: Only add language dropdown when there has more than one locale configured. (vuejs#181)

* 0.7.1

* chore: changelog

* fix: Fix the style of repo link.

* fix margin

* docs: Update Multi-Language Support (vuejs#192)

* chore: unexpected `background-color` value from code block (vuejs#217)

* feat: support toml config (vuejs#138)

* feat: support toml config

* remove config.toml

* fix: proper iteration over meta tags

* feat: support built-in pug config and document using pro-processors at component (vuejs#151)

* feat: theme index enhancment support (vuejs#154)

* feat: Add docsRepo (vuejs#155)

* feat: expose all css pre-processor's options. (close vuejs#169) (vuejs#178)

* docs: clarify documentation on how to use links (vuejs#188)

* docs(multiple sidebars): clarify documentation (vuejs#190)

* docs: add example for nested custom components (vuejs#195)

* feat: support for TOML front matter (vuejs#141) (vuejs#164)

* feat: add max search suggestions config (vuejs#163)

* fix: fix emoji not showing on sidebars (vuejs#206)

* fix: fix Sidebar link active logic (vuejs#215)

* refactor: remove unnecessary method

* fix: fix title inferrence regression (close vuejs#208)

* fix: siteTitle vs pageTitle

* feat: support excerpt extraction with `<!-- more -->` (close vuejs#174)

* docs: tweak deploy guide

* fix: default to localhost on windows (close vuejs#221)

* docs: add deploy guide for firebase (vuejs#213)

* docs: add deploy guide for GitLab pages + GitLab CI (vuejs#219)

* tweak: improve mobile UX for sidebar links (vuejs#212)

* docs: add .vuepress/override.styl reference (vuejs#224)

* feat: Algolia DocSearch Integration  (vuejs#201)

* refactor: load theme/enhanceApp.js instead of index.js

* feat: also expose siteData in enhanceApp.js

* fix: renames index.js to enhanceApp.js (vuejs#226)

* docs: new content for new feautures

* fix: algolia check should be checking themeConfig.algolia

* docs: more updates

* docs(cn): add section for custom page class

* 0.8.0

* chore: changelog

* fix: algolia regression (close vuejs#228)

* 0.8.1

* chore: changelog

* fix: nav-item underline use $accentColor (vuejs#230)

* feat: expose layout slots for injecting custom content

* docs: use extended theme

* tweak: use lighter underline

* 0.8.2

* chore: changelog

* chore: vuepress-theme-vue should be a dev dep

* fix: always write override.style

* 0.8.3

* chore: changelog

* feat: support disable navbar via front matter (close: vuejs#187) (vuejs#232)

* docs: update for disabling navbar via front matter (vuejs#232)

* doc: correct file extension (vuejs#236)

* fix: algolia regression - missing options (close vuejs#234)

* 0.8.4

* chore: changelog

* refactor: use css-loader/locals in ssr bundle

* tweak: add home link on 404 page

* tweak: cursor on search box should be text (vuejs#244)

* fix: avoid the searchbox exceeded out of screen in narrow screen (vuejs#254)

* tweak: add cursor pointer in li (vuejs#247)

* fix: potential duplicate iteration keys at dropdown (vuejs#249)

* feat: support disable navbar globally (vuejs#246)

* docs: update doc for disabling navbar globally (vuejs#246)

* docs: update Chinese translation for deploying.

* docs: add a tip for built-in search and fix typo (vuejs#262)

* docs(cn): add tip for built-in search (vuejs#262)

* chore: lint code (vuejs#264)

* workflow: upgrade eslint-plugin-vue-libs

* refactor: move noopModule

* docs: add note about gitbook

* docs: Gitbook -> GitBook

* chore: bump theme

* docs(cn): fix typo (vuejs#275)

* feat: highlight current region in sidebar (vuejs#272)

* chore: update yarn.lock

* fix: relative link checking

* fix: ensure `<script>` blocks in SFCs in node_modules are transpiled

* feat: hide edit link by page (close: vuejs#284) (vuejs#286)

* docs(cn): update doc for hiding edit link by page (vuejs#286)

* feat: header extraction improvement (close: vuejs#238) (vuejs#271)

* feat: sidebar header extraction improvements (close: vuejs#238)

* chore: add more markdown tokens to be removed

* fix: typo

* chore: show warnings in build debug mode (vuejs#285)

* chore: remove colon in stylus of NavLinks (vuejs#299)

* docs: add missing < (vuejs#302)

* docs(cn): add missing <

* fix: title cannot be number at front matter (vuejs#297)

* fix: unexpected scroll behavior after clicking sidebar links (vuejs#298)

* docs(cn): tweaks (vuejs#312)

* fix: index file judgement bug (close: vuejs#306) (vuejs#308)

* chore: log error when set outDir to cwd (close: vuejs#322) (vuejs#324)

* feat: handle telephone links (vuejs#325)

* refactor: avoid using regexp's lookbehind (vuejs#323)

* docs: link LICENSE (vuejs#328)

* fix: unexpected top blank space when navbar is disable (vuejs#316)

* docs: link some items at README

* docs: fix typo (vuejs#333)

* docs: use explicit link for LICENSE

* docs: add some shields badges to README

* docs: use rawgit logo to make it display at npm page.

* refactor: make the prepare process clearer and modify the resolve alias (vuejs#277)

* feat: generate the timestamp of last updated for each doc (close vuejs#258) (vuejs#282)

* fix: code looks not good at small sreen (close: vuejs#350)

* feat: make code type insensitive (close: vuejs#347)

* docs: add surge deploy instructions (vuejs#352)

* docs(cn): add surge deploy instructions (vuejs#352)

* feat: support global markdown config for attributes of external links (vuejs#358)

* docs(cn): support global md config for attributes of external links (vuejs#358)

* fix: duplicate slash when docs dir is not set (vuejs#361)

* fix: dropdown overlap due to word wrapping (close: vuejs#359) (vuejs#360)

* feat: last updated UI in default theme. (vuejs#338)

* docs: tweaks themeConfig.editLinks (vuejs#378)

* docs(cn): tweaks themeConfig.editLinks (vuejs#378)

* fix: image overflow at custom content (close: vuejs#381) (vuejs#383)

* fix: postcss-loader warnings (close: vuejs#278)

* feat: using babel and support JSX in vue. (close: vuejs#318) (vuejs#336)

* docs: add heroku deploy instructions (vuejs#366)

* chore: update yarn.lock

* fix: $page is missing at 404 page (vuejs#388)

* fix: resolve custom theme from global cli (close: vuejs#392) (vuejs#399)

* feat: bump up webpack to 4.8.1 (close: vuejs#309)

* docs(cn): add heroku deploy instructions (vuejs#366)

* docs(cn): tweaks service worker (vuejs#406)

* fix: remove style override limitation to custom theme (close: 404) (vuejs#405)

* docs: add some links (vuejs#403)

* fix: glob patterns error on windows (close: vuejs#348) (vuejs#400)

* docs(cn): add links

* fix: missing title and desc in 404 and custom theme.

* chore: tweaks

* Revert "fix: code looks not good at small sreen (close: vuejs#350)"

This reverts commit 6514c8f.

* fix: code looks not good at small sreen (close: vuejs#350)

* chore: fix typo

* refactor: root mixins injection (vuejs#423)

* docs: tweaks (vuejs#422)

* fix: emoji doesn't work in toc (close: vuejs#417) (vuejs#418)

* refactor: hoist pre wrapper as a standalone plugin.

* refactor(babel-loader): resolve absolute module paths (vuejs#436)

* chore: fix typo in home styling (vuejs#435)

* chore: add language ts support (vuejs#431)

* chore: allow class and style merging for content (vuejs#430)

* docs: fix links typo (vuejs#427)

* fix: highlight line issue for empty lines

* fix: highlight lines are cut when sliding (vuejs#437)

* fix: upgrade webpack-serve and avoid port conflict (close vuejs#424) (vuejs#425)

* fix: use v-for with key (vuejs#438)

* feat: show OutboundLink icon for external links (vuejs#428)

* docs: tweaks quote syntax (vuejs#440)

* docs(cn): tweaks quote syntax (vuejs#440)

* docs: avoid indent in code block

* feat: code line numbers (close: vuejs#365) (vuejs#379)

* refactor: use stylus iteration to generate the lang tip

* fix: nav link highlight issue with i18n (close: vuejs#445)

* feat: support style lang postcss (close: vuejs#461)

* feat: support render $page.excerpt to HTML (close: vuejs#458)

* chore: fix typo

* fix: missing css source map at dev environment (vuejs#460)

* chore: tweaks yarn.lock

* chore: upgrade dependencies to make it work at node 10. (vuejs#456)

* fix: highlight active link (vuejs#272) doesn't work with non-EN hash.

* docs: fix typo (vuejs#467)

* docs: fix typo (vuejs#466)

* fix: unexpected warning when using non-ASCII chars as filename.

* chore: fix a stylus syntax error (vuejs#474)

* doc: update for changing config of markdown-it (vuejs#477)

* docs(cn): update for changing config of markdown-it (vuejs#477)

* refactor: move loadConfig into util

* perf: vastly improve rebuild perf with caching

* workflow: use cc cli

* 0.9.0

* chore: changelog

* workflow: update issue templates

* workflow: add pull request template

* workflow: update issue template

* feat: allow for disabling of active hash on scroll (vuejs#489)

* refactor: load 'active header links' on demand

* docs: update docs for 'active header links'

* chore: remove console

* workflow: update pull request template

* feat: support filename that contains non-ASCII and unicode chars (vuejs#473)

* docs: tweaks active header links

* refactor: unify style of function.

* fix: lastUpdated looks bad when editLinks is false.

* fix: wrong OutboundLink insertion position (close: vuejs#496)

* docs: fix typo (vuejs#498)

* Translate config for v0.9.0

* fix: avoid cache error (close vuejs#492)

* fix: fix config reload cache busting

* 0.9.1

* chore: changelog

* feat: upgrade to babel 7 + use @vue/babel-preset-app

* 0.10.0

* chore: changelog

* feat: better log (vuejs#506)

* Translate config for v0.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment