Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): do not transpile core packages' dependencies #1771

Open
wants to merge 1 commit into
base: master
from

Conversation

@sodatea
Copy link
Member

commented Aug 12, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Didn't have the time to get a minimal reproduction, but here's the error log I've got after upgrading to vuepress 1.0.3: https://app.netlify.com/sites/vue-cli/deploys/5d51074c57e52800094f95af
Seems it's trying to transpile the core-js package and failed.
The change was added in #1685 and was trying to fix #1623. But I think adding the entry files of core plugins is enough to ensure babel's polyfill detection to work, so I excluded the nested node_modules directory in the path pattern.

sodatea added a commit to vuejs/vue-cli that referenced this pull request Aug 12, 2019

fix: lock vuepress version, fixes documentation deployment
Need to stick to 1.0.2 until vuejs/vuepress#1771
is merged & released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.