Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing emoji not showing on sidebars #206

Merged
merged 2 commits into from Apr 23, 2018
Merged

Conversation

@ycmjason
Copy link
Contributor

@ycmjason ycmjason commented Apr 22, 2018

Emojis could be written on titles of markdown, but they will not show on the sidebar. So this PR basically contains:

  • Fixing for emoji showing as source (e.g. :tada:) on sidebar
  • Added an emoji to the emoji section to show that this is possible
@ycmjason ycmjason force-pushed the ycmjason:emoji-title-parsing branch from c96bdab to 2d3e808 Apr 22, 2018
@yyx990803 yyx990803 merged commit bc2c83a into vuejs:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants