Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deploy guide for firebase #213

Merged
merged 5 commits into from Apr 23, 2018
Merged

Conversation

@ycmjason
Copy link
Contributor

@ycmjason ycmjason commented Apr 22, 2018

No description provided.

@mdaffin
Copy link
Contributor

@mdaffin mdaffin commented Apr 23, 2018

Should the .firebaserc and firebase.json files not exist at the project root level? With "public": "docs/.vuepress/dist", (or where your actual dist exists) in the firebase.json? Then there is no need for a wrapper script and firebase deploy can be added to the package.json's script section directly.

@ycmjason
Copy link
Contributor Author

@ycmjason ycmjason commented Apr 23, 2018

Good idea! Will change this now! 🥂

@ycmjason
Copy link
Contributor Author

@ycmjason ycmjason commented Apr 23, 2018

@mdaffin I have updated the guide, do you want to review this again please?

@mdaffin
Copy link
Contributor

@mdaffin mdaffin commented Apr 23, 2018

Much better, though I think you should use docs/.vuepress/dist to keep it consistent with the netlify instructions. Then I think you also don't require the ignore part as everything in dist should be included?

@ycmjason
Copy link
Contributor Author

@ycmjason ycmjason commented Apr 23, 2018

@mdaffin
Yeah you are right. I have also fixed github pages script for not using docs/.vuepress/dist.

yyx990803 added 2 commits Apr 23, 2018
@yyx990803 yyx990803 merged commit 5a175c3 into vuejs:master Apr 23, 2018
1 check was pending
1 check was pending
deploy/netlify Deploy preview processing.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants