New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the document more stable by removing stage-x for object separate syntax while it can be changed in the future #1439

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@tuanlc
Contributor

tuanlc commented Nov 4, 2018

The stage of object spread syntax has been changed to 4

@@ -86,7 +86,7 @@ Since a Vuex store's state is made reactive by Vue, when we mutate the state, Vu
- Use `Vue.set(obj, 'newProp', 123)`, or
- Replace that Object with a fresh one. For example, using the stage-3 [object spread syntax](https://github.com/sebmarkbage/ecmascript-rest-spread) we can write it like this:
- Replace that Object with a fresh one. For example, using the stage-4 [object spread syntax](https://github.com/sebmarkbage/ecmascript-rest-spread) we can write it like this:

This comment has been minimized.

@ktsn

ktsn Nov 5, 2018

Member

Would you mind to remove "stage-X" instead? Because we receive this kind of PRs repeatedly and it actually is not so important I think.

This comment has been minimized.

@tuanlc

tuanlc Nov 6, 2018

Contributor

Hi,
I was reading the Vuex documentation and saw the out-dated information.
Yes, agree that it is not so important.

Removed "stage-x".

Makes the document more stable by removing stage-x for object separat…
…e syntax while it can be changed in the future

The stage of [object spread syntax](https://github.com/sebmarkbage/ecmascript-rest-spread) has been changed to 4

@tuanlc tuanlc force-pushed the tuanlc:patch-1 branch from 4271606 to 050dbcf Nov 6, 2018

@tuanlc tuanlc changed the title from Update tc39 stage to 4 for object spread syntax to Makes the document more stable by removing stage-x for object separate syntax while it can be changed in the future Nov 6, 2018

@ktsn

ktsn approved these changes Nov 7, 2018

Thank you!

@ktsn ktsn merged commit de05152 into vuejs:dev Nov 7, 2018

6 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment