New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replaced video preview code to a VideoPreview component #1453

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@Jinjiang
Member

Jinjiang commented Nov 20, 2018

... for better maintenance and translation.
Ref: https://v0.vuepress.vuejs.org/guide/using-vue.html#using-components
Thanks.

@ktsn

This comment has been minimized.

Member

ktsn commented Nov 26, 2018

Cool! 👍

One thing I found is the video is no longer auto played after clicking placeholder image. We also need to click the play button in the iframe video...
This probably is because it is needed to play it in the user's click callback on Chrome while the iframe is now appeared by v-if directive.
Can you modify it to behave as same as before?

@Jinjiang

This comment has been minimized.

Member

Jinjiang commented Nov 26, 2018

@ktsn well I found it worked in Safari which is my preference. But yes it failed in Chrome. 😅
Sorry for my lack of testing, will check it out soon. 👌
Thanks.

@ktsn

ktsn approved these changes Nov 27, 2018

Thanks! 👍

@ktsn ktsn merged commit 2dfdd83 into vuejs:dev Nov 27, 2018

6 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@Jinjiang Jinjiang deleted the Jinjiang:video branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment