Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Scrimba lessons #1512

Merged
merged 5 commits into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@perborgen
Copy link
Contributor

perborgen commented Feb 20, 2019

Here are the Scrimba lessons localized and with an override.styl file for the styling. Did I do it right?

@yyx990803
Copy link
Member

yyx990803 left a comment

screen shot 2019-02-20 at 4 41 34 pm

Let's give this a bit more margin at top?

@perborgen

This comment has been minimized.

Copy link
Contributor Author

perborgen commented Feb 21, 2019

Added a margin-top of 16 px, as that's similar to what the paragraphs have.

@yyx990803 yyx990803 merged commit 041df8d into vuejs:dev Feb 21, 2019

6 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.