Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor errors in README.md #1523

Merged
merged 3 commits into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@dollinad
Copy link
Contributor

dollinad commented Mar 16, 2019

Changes involve:

  • Removal of dead links: data flow.png and vuex.png
  • Removal of discourse markers (although, also, in addition) to make sentences precise
Fix minor errors in README.md
Changes involve:
- Removal of dead links: data flow.png and vuex.png
- Removal of discourse markers (although, also, in addition) to make sentences precise
@ktsn

This comment has been minimized.

Copy link
Member

ktsn commented Mar 17, 2019

Removal of dead links

Well, it's not dead links actually. https://vuex.vuejs.org/

Updated Edits
Re-added link for Vuex
@dollinad

This comment has been minimized.

Copy link
Contributor Author

dollinad commented Mar 17, 2019

Updated!

Re-added link https://vuex.vuejs.org/

@ktsn

This comment has been minimized.

Copy link
Member

ktsn commented Mar 17, 2019

I mean flow.png and vuex.png is not dead links. Could you restore them?
You can see the rendered docs of this PR in https://deploy-preview-1523--vuex-docs.netlify.com/ or by npm run docs in your local.

Update edits1
Readded flow.png and veux.png

@ktsn ktsn merged commit d072724 into vuejs:dev Mar 17, 2019

6 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

ktsn added a commit that referenced this pull request Mar 17, 2019

@ktsn

This comment has been minimized.

Copy link
Member

ktsn commented Mar 17, 2019

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.