Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): avoid broadening vue instance type when using map helpers #1639

Merged
merged 2 commits into from Nov 10, 2019

Conversation

@ktsn
Copy link
Member

ktsn commented Nov 10, 2019

fix #1119

@ktsn ktsn merged commit 9a96720 into vuejs:dev Nov 10, 2019
6 checks passed
6 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@ktsn ktsn deleted the ktsn:precise-map-helper-types branch Nov 10, 2019
@DanielRuf

This comment has been minimized.

Copy link

DanielRuf commented Dec 11, 2019

I still get the issue with missing properties even if they are declared. Seems it does not use this from the component instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.