Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: todomvc case failed in windows and some linux os (#1899) #1908

Merged
merged 1 commit into from Jan 5, 2021

Conversation

@Alanscut
Copy link
Contributor

@Alanscut Alanscut commented Dec 21, 2020

As clear-completed button is part of footer, although we expect await click('footer') will trigger the footer element, however it actually triggered the clear-completed button, so the next asserts will failed. 4.0 branch has the same problem.

await click('footer') // blur
expect(await count('.todo.editing')).toBe(0)
expect(await text('.todo:nth-child(1) label')).toBe('edited!')

change click footer to .todo-count will make sure test cases pass, which could fix #1899.

@kiaking
Copy link
Member

@kiaking kiaking commented Jan 5, 2021

Ah thanks! Didn't see this PR. Yap, this is working and seems to be good fix. Thanks a lot 🙌

@kiaking kiaking added the test label Jan 5, 2021
@kiaking kiaking changed the title fix #1899: todomvc case failed in windows and some linux os test: todomvc case failed in windows and some linux os (#1899) Jan 5, 2021
@kiaking kiaking merged commit 13cd6ab into vuejs:dev Jan 5, 2021
6 checks passed
6 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@Alanscut Alanscut deleted the Alanscut:fix-issue1899 branch Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants