Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdChips] feedback for duplicated chip input value #1212

Closed
VdustR opened this Issue Nov 23, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@VdustR
Copy link
Member

VdustR commented Nov 23, 2017

MdChips reject duplicated value.

It just do nothing while trying to insert a duplicated value.

There should be a feedback let users know it's duplicated, like: shake the duplicated chip or some else anime effects.

@marcosmoura marcosmoura self-assigned this Nov 24, 2017

@Samuell1

This comment has been minimized.

Copy link
Member

Samuell1 commented Dec 7, 2017

Maybe mark same chip with accent color?

VdustR added a commit to VdustR/vue-material that referenced this issue Dec 8, 2017

feat(MdChips): feedback for duplicated chip
add `md-duplicated` class which has the same style as `md-accent`. add
`md-check-duplicated-on-change` props.

fix vuematerial#1212

VdustR added a commit to VdustR/vue-material that referenced this issue Dec 8, 2017

marcosmoura added a commit that referenced this issue Dec 19, 2017

feat(MdChips): feedback for duplicated chip (#1281)
* feat(MdChips): feedback for duplicated chip

add `md-duplicated` class which has the same style as `md-accent`. add
`md-check-duplicated-on-change` props.

fix #1212

* fix(MdChips): change api `mdCheckDuplicatedOnChange` to `mdAlwaysCheckDuplicated`

* fix(MdChips): change for loop key from `key` to `chip` to prevent triggering animate while removing

* docs(MdChips): example and new props for duplicated chip checking

fix #1212

* fix(MdChips): always clear `duplicatedChip` on change

* style(MdChips): fix style to pass scss-lint

* fix(MdChips): rename prop

* fix(MdChips): rename prop

* fix(MdChips): rename prop

* fix(MdChips): rename prop

* style(MdChips): adjust code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.