Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdSelect] options in disabled groups are selectable #1286

Closed
VdustR opened this Issue Dec 9, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@VdustR
Copy link
Member

commented Dec 9, 2017

Steps to reproduce

Check the official documentation, and scroll down to "Disabled" example area. Select the disabled groups.

Which browser?

vue-material@1.0.0-beta-7

What is expected?

Those options in disabled groups should be un-selectable.

What is actually happening?

You can select the options in the disabled group.

Reproduction Link

official documentation

@hiddenwaffle

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2017

I am still very new to this codebase, but I suspect that if this line were changed from checking "this.disabled" to "this.isDisabled" it would give the correct behavior:


My reasoning is that isDisabled() accounts for the injected "MdOptgroup" property, which appears to allow the component to inherit whether or not it is disabled based on the parent component.

@VdustR

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

@hiddenwaffle thanks, that helps!

marcosmoura added a commit that referenced this issue Dec 22, 2017

fix(MdSelect): make options in disabled groups un-selectable (#1293)
* fix(MdSelect): make options in disabled groups un-selectable

fix #1286

* fix(MdSelect): make multiple selection checkboxes effective

* style(MdOption): remove empty lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.