Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability - Components implementing a href attribute to render <a> tags and accepting the target="_blank" option should implement rel="noopener noreferrer" #1320

Closed
emman27 opened this Issue Dec 21, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@emman27
Copy link
Contributor

emman27 commented Dec 21, 2017

e.g. If used as

<md-list-item :href="http://virus.com" target="_blank" rel="noopener noreferrer">A malicious link</md-list-item>

then only the li tag encapsulating the actual a tag is given the attribute. This is a security vulnerability as the opened tab can gain access to the current window.

@VdustR VdustR added the improvement label Dec 22, 2017

VdustR added a commit to VdustR/vue-material that referenced this issue Dec 22, 2017

feat(MdListItemLink): all `<a>` attributes supported
`<a>` attributes `download`, `hreflang`, `ping`, `rel`, `type` supported

fix vuematerial#1320

marcosmoura added a commit that referenced this issue Dec 22, 2017

feat(MdListItemLink): add all `<a>` attributes supported (#1328)
`<a>` attributes `download`, `hreflang`, `ping`, `rel`, `type` supported

fix #1320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.