Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MdDatepicker): override browser native pickers #1270

Merged
merged 4 commits into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@Samuell1
Copy link
Member

commented Dec 6, 2017

close #1267, #1260

this.showDialog = !this.showDialog
} else {
this.$refs.input.$el.click()
}

This comment has been minimized.

Copy link
@VdustR

VdustR Dec 7, 2017

Member

I think it's better to remove nested statement

if (!isFirefox || this.mdOverrideNative) {
  this.showDialog = !this.showDialog
} else {
  this.$refs.input.$el.click()
}

@marcosmoura marcosmoura merged commit 1cfaf3c into dev Dec 19, 2017

3 of 4 checks passed

deploy/netlify Deploy preview failed.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marcosmoura marcosmoura deleted the feat/MdDatepicker/override-browser-native-picker branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.