Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdMenu): fix close-on-select props #1280

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@VdustR
Copy link
Member

commented Dec 8, 2017

check whether clicked target is contained in menu content element within bodyClickObserver

I found that this.$el is always <!-- --> here. Add a statement isMenuContentEl to prevent menu closing from bodyClickObserver.

MdMenu, MdSelect, MdAutocomplete tested.

Note that md-close-on-select only fire close event fired while there are one or more interaction events bound on md-menu-item

fix #1279

fix(MdMenu): fix close-on-select props
check whether clicked target is contained in menu content element within `bodyClickObserver`

fix #1279

@marcosmoura marcosmoura merged commit 40406af into vuematerial:dev Dec 19, 2017

4 of 5 checks passed

codeclimate/diff-coverage 0% (50% threshold)
Details
codeclimate All good!
Details
codeclimate/total-coverage 34% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@VdustR VdustR deleted the VdustR:fix#1279 branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.