Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix #1261) Don't emit input directly in MdInput and MdTextarea #1285

Merged
merged 2 commits into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@korylprince
Copy link
Contributor

korylprince commented Dec 8, 2017

Fixes #1261.

Notes: use Object.assign to deep copy this.$listeners. delete input key as opposed to setting to undefined which causes error.

...this.$listeners,
input: event => this.$emit('input', event.target.value)
}
var l = Object.assign({}, this.$listeners)

This comment has been minimized.

Copy link
@marcosmoura

marcosmoura Dec 19, 2017

Member

Object.assign is not available for all browsers.

@korylprince

This comment has been minimized.

Copy link
Contributor Author

korylprince commented Dec 19, 2017

Sorry! I thought Object.assign was transformed by babel. I've changed it over to the spread operator which is transformed by your babel config.

@marcosmoura marcosmoura merged commit 00832e9 into vuematerial:dev Dec 22, 2017

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.