Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node type statement(menu compatibility with IE) #1365

Merged
merged 2 commits into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@VdustR
Copy link
Member

VdustR commented Jan 3, 2018

dom constructors do not have name property in IE.

Replace that with comparing by their node type.

Tested with chrome and IE(with #1342), both got 1 stand for normal element and got 8 for comment.

Related to #1263

There is another bug with #1263 that menuHeight is always 0 therefore menu still not works in IE with this change yet.

update: fix height with 24d927c, similar to #1356

fix #1263

IE11 & edge in Win10(VirtualBox), firefox & chrome in Xubuntu tested.

MdMenu, MdSelect, MdAutocomplete tested.

VdustR added some commits Jan 3, 2018

fix: compare node by type
dom constructors do not have name property in IE.
replace that with comparing by their node type.

fix #1263
fix(MdMenuContent): height for IE
got height `0` with style `flex-direction: column`

fix #1263

@VdustR VdustR changed the title fix: node type statement fix: node type statement(menu compatibility with IE) Jan 3, 2018

@marcosmoura marcosmoura merged commit a4c03be into vuematerial:dev Jan 3, 2018

4 of 5 checks passed

codeclimate/diff-coverage 0% (50% threshold)
Details
codeclimate All good!
Details
codeclimate/total-coverage 34% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@VdustR VdustR deleted the VdustR:fix#1263 branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.