Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdFieldMixin) Preserve the name attribute on change #1385

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
3 participants
@jastkand
Copy link
Contributor

jastkand commented Jan 9, 2018

I've created a codepen which demonstrates an issue: https://codepen.io/jastkand/pen/EoQGKV

You can open a devtools and see that there are name attributes on input and textarea. When you try to change any input the name attribute will be removed which is not an expected behavior.

This also should fix this issue #1278, because serialization uses name attributes

@marcosmoura
Copy link
Member

marcosmoura left a comment

Oh my god! You created tests! Thank you! <3

@marcosmoura
Copy link
Member

marcosmoura left a comment

Oh my god! You created tests! Thank you! <3

@marcosmoura marcosmoura merged commit 0a83834 into vuematerial:dev Jan 12, 2018

2 of 3 checks passed

deploy/netlify Deploy preview failed.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jastkand jastkand deleted the jastkand:preserve-name-attribute branch Jan 12, 2018

@CharlesKumar

This comment has been minimized.

Copy link

CharlesKumar commented Jan 29, 2018

when this change gonna be in the release (atleast in next beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.