Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MdDatepicker): custom first day of a week #1409

Merged
merged 3 commits into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@VdustR
Copy link
Member

commented Jan 17, 2018

new props md-first-day-of-a-week for customizing first day of a week.

fix #1397

feat(MdDatepicker): custom first day of a week
new props `md-first-day-of-a-week` for custom first day of a week.

fix #1397
@marcosmoura

This comment has been minimized.

Copy link
Member

commented Jan 17, 2018

I this shouldn't be a prop. Because for multiple Datepicker fields it will take a lot of effort to set the prop to it!
There is a global config that we can use.

What do you think? Can you change that?

VdustR added some commits Jan 17, 2018

feat(MdDatepicker): custom first day of a week
global config `locale.firstDayOfAWeek`

fix #1397
@VdustR

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2018

Update:
Remove the props and use Vue.material.locale.firstDayOfAWeek or this.$material.locale.firstDayOfAWeek in Vue instance for global config.

@marcosmoura marcosmoura merged commit af0dc0a into vuematerial:dev Jan 23, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@VdustR VdustR deleted the VdustR:feat#1397 branch Jan 23, 2018

marcosmoura pushed a commit that referenced this pull request Jan 29, 2018

Merge remote-tracking branch 'origin/dev'
* origin/dev: (72 commits)
  docs: add ie polyfills (#1342)
  fix(MdTooltip): `mdActive` never updated to true using `.sync` modifier
  chore: new component script (#1455)
  fix(MdTabs): fix indicator (#1448)
  fix(MdSelect): Reactive options (#1447)
  fix(MdTooltip): overlaying in dialog (#1446)
  fix(MdTabs): correct indicator position while alignment changed (#1442)
  fix(MdProgressSpinner): undefined navigator on SSR (#1441)
  docs(MdTabs): add missing md-icon prop (#1439)
  fix(MdRipple): clear ripples if called programatically (#1431)
  feat(MdListItemExpand): reactive expansion (#1435)
  feat(MdDatepicker): emit date without confirming (#1426)
  feat(MdDatepicker): add dateformat (#1436)
  feat(MdRipple): multiple waves (#1419)
  feat(MdDatepicker): custom first day of a week (#1409)
  feat(MdDatepicker): remove fixed label position (#1417)
  docs(MdDialog): add note about scrollable content (#1416)
  Update sponsorship links (#1427)
  fix(MdAutocomplete): prevent show options twice (#1410)
  fix(MdField): Consider number `0` as hasValue (#1407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.