Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MdRipple): multiple waves #1419

Merged
merged 4 commits into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@Samuell1
Copy link
Member

commented Jan 21, 2018

2018-01-21_19-06-22

@Samuell1 Samuell1 requested review from marcosmoura and VdustR Jan 21, 2018

}, delay)
}
}

This comment has been minimized.

Copy link
@VdustR

VdustR Jan 22, 2018

Member

I think this method could put it into /src/core/utils and name it MdDebounce.

It could be shorter with es6:

  const debounce = (fn, delay) => {
    let timeoutID = null
    return (...args) => {
      clearTimeout(timeoutID)
      timeoutID = setTimeout(() => fn(...args), delay)
    }
  }

@marcosmoura marcosmoura merged commit 70b3aa2 into dev Jan 23, 2018

5 of 6 checks passed

codeclimate/total-coverage 33% (-0.1% change)
Details
codeclimate All good!
Details
codeclimate/diff-coverage 50% (50% threshold)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@marcosmoura marcosmoura deleted the feat/MdRipple/multiple-waves branch Jan 23, 2018

marcosmoura pushed a commit that referenced this pull request Jan 29, 2018

Merge remote-tracking branch 'origin/dev'
* origin/dev: (72 commits)
  docs: add ie polyfills (#1342)
  fix(MdTooltip): `mdActive` never updated to true using `.sync` modifier
  chore: new component script (#1455)
  fix(MdTabs): fix indicator (#1448)
  fix(MdSelect): Reactive options (#1447)
  fix(MdTooltip): overlaying in dialog (#1446)
  fix(MdTabs): correct indicator position while alignment changed (#1442)
  fix(MdProgressSpinner): undefined navigator on SSR (#1441)
  docs(MdTabs): add missing md-icon prop (#1439)
  fix(MdRipple): clear ripples if called programatically (#1431)
  feat(MdListItemExpand): reactive expansion (#1435)
  feat(MdDatepicker): emit date without confirming (#1426)
  feat(MdDatepicker): add dateformat (#1436)
  feat(MdRipple): multiple waves (#1419)
  feat(MdDatepicker): custom first day of a week (#1409)
  feat(MdDatepicker): remove fixed label position (#1417)
  docs(MdDialog): add note about scrollable content (#1416)
  Update sponsorship links (#1427)
  fix(MdAutocomplete): prevent show options twice (#1410)
  fix(MdField): Consider number `0` as hasValue (#1407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.