Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MdDatepicker): emit date without confirming #1426

Merged
merged 5 commits into from Jan 24, 2018

Conversation

Projects
None yet
3 participants
@Samuell1
Copy link
Member

commented Jan 23, 2018

Resolves #1424

@VdustR

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Just an idea: would there be a clear button for clearing the value and keep cancel closing the dialog?

@Samuell1

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2018

I think cancel is okay, it should be like this because you cancel selecting a date not a close a datepicker

@marcosmoura

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

I think that should have a clear button instead. Something like the clear button with the 'md-clearable' on md-field. This will separate the responsibilities from closing the dialog without changing the date (maybe the user opened it by mistake or just to check if it's correct or not, by looking at the full calendar month), clearing the field form the proper clear button and confirming the new/old date. This will also be compliant with the guidelines!

What do you guys think? @Samuell1 @VdustR

@VdustR

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Agree.

Samuell1 added some commits Jan 23, 2018

@marcosmoura marcosmoura merged commit e4af731 into dev Jan 24, 2018

5 of 6 checks passed

codeclimate/diff-coverage 0% (50% threshold)
Details
codeclimate All good!
Details
codeclimate/total-coverage 33% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@marcosmoura marcosmoura deleted the feat/MdDatepicker/emit-date-without-confirming branch Jan 24, 2018

marcosmoura pushed a commit that referenced this pull request Jan 29, 2018

Merge remote-tracking branch 'origin/dev'
* origin/dev: (72 commits)
  docs: add ie polyfills (#1342)
  fix(MdTooltip): `mdActive` never updated to true using `.sync` modifier
  chore: new component script (#1455)
  fix(MdTabs): fix indicator (#1448)
  fix(MdSelect): Reactive options (#1447)
  fix(MdTooltip): overlaying in dialog (#1446)
  fix(MdTabs): correct indicator position while alignment changed (#1442)
  fix(MdProgressSpinner): undefined navigator on SSR (#1441)
  docs(MdTabs): add missing md-icon prop (#1439)
  fix(MdRipple): clear ripples if called programatically (#1431)
  feat(MdListItemExpand): reactive expansion (#1435)
  feat(MdDatepicker): emit date without confirming (#1426)
  feat(MdDatepicker): add dateformat (#1436)
  feat(MdRipple): multiple waves (#1419)
  feat(MdDatepicker): custom first day of a week (#1409)
  feat(MdDatepicker): remove fixed label position (#1417)
  docs(MdDialog): add note about scrollable content (#1416)
  Update sponsorship links (#1427)
  fix(MdAutocomplete): prevent show options twice (#1410)
  fix(MdField): Consider number `0` as hasValue (#1407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.