Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdTabs): fix indicator #1448

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@VdustR
Copy link
Member

commented Jan 26, 2018

right: `calc(100% - ${buttonWidth + buttonLeft}px)` work weird with safari, replace it with width way to set indicator position

fix #1304

fix(MdTabs): fix indicator
right: `calc(100% - ${buttonWidth + buttonLeft}px)` work weird with safari, replace it with `width`
way to set indicator position

fix #1304
@marcosmoura

This comment has been minimized.

Copy link
Member

commented Jan 26, 2018

We can use this for now, but the transition of the indicator do not follow the guidelines with this change.

@marcosmoura marcosmoura merged commit b33d0d6 into vuematerial:dev Jan 26, 2018

5 checks passed

codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 33% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@VdustR VdustR deleted the VdustR:fix#1304 branch Jan 27, 2018

marcosmoura pushed a commit that referenced this pull request Jan 29, 2018

Merge remote-tracking branch 'origin/dev'
* origin/dev: (72 commits)
  docs: add ie polyfills (#1342)
  fix(MdTooltip): `mdActive` never updated to true using `.sync` modifier
  chore: new component script (#1455)
  fix(MdTabs): fix indicator (#1448)
  fix(MdSelect): Reactive options (#1447)
  fix(MdTooltip): overlaying in dialog (#1446)
  fix(MdTabs): correct indicator position while alignment changed (#1442)
  fix(MdProgressSpinner): undefined navigator on SSR (#1441)
  docs(MdTabs): add missing md-icon prop (#1439)
  fix(MdRipple): clear ripples if called programatically (#1431)
  feat(MdListItemExpand): reactive expansion (#1435)
  feat(MdDatepicker): emit date without confirming (#1426)
  feat(MdDatepicker): add dateformat (#1436)
  feat(MdRipple): multiple waves (#1419)
  feat(MdDatepicker): custom first day of a week (#1409)
  feat(MdDatepicker): remove fixed label position (#1417)
  docs(MdDialog): add note about scrollable content (#1416)
  Update sponsorship links (#1427)
  fix(MdAutocomplete): prevent show options twice (#1410)
  fix(MdField): Consider number `0` as hasValue (#1407)
  ...

VdustR added a commit to VdustR/vue-material that referenced this pull request Mar 18, 2018

marcosmoura added a commit that referenced this pull request Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.