Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdTable): fix double default slots #1731

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
4 participants
@Samuell1
Copy link
Member

commented May 14, 2018

Simple table without v-model is rendering default slots 2 times.
Reproduction: https://codesandbox.io/s/1qy64o65j?module=App.vue

@VdustR

VdustR approved these changes May 14, 2018

@marcosmoura marcosmoura merged commit 3c61bcf into dev May 14, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codeclimate All good!
Details
deploy/netlify Deploy preview ready!
Details

@marcosmoura marcosmoura deleted the fix/MdTable/fix-slot branch May 14, 2018

marcosmoura added a commit that referenced this pull request May 15, 2018

Merge remote-tracking branch 'origin/dev'
* origin/dev:
  test(MdSwitch): fix test script (#1739)
  test(MdCheckbox): fix test script (#1737)
  test(MdBadge): fix test script (#1736)
  fix(MdTable): fix table rendering default slot twice (#1731)
@fabioviana-hotmart

This comment has been minimized.

Copy link

commented Jul 13, 2018

This problem still occurs when it has the component md-table-pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.