Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Setting iconPrefix to '' don't work #2093

Closed
Ackerven opened this issue Jul 28, 2022 · 5 comments
Closed

[Bug] Setting iconPrefix to '' don't work #2093

Ackerven opened this issue Jul 28, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Ackerven
Copy link
Contributor

Describe the feature

When using the fontawesome icon in the theme, only the icon filtered by the Solid, Free condition can be used.
Like:
image

However,the icons in the brands collection are also free, but cannot be used.
So icons like some languages cannot be used.
For example:
image

image

Additional context

No response

@Ackerven Ackerven added the enhancement New feature or request label Jul 28, 2022
@Ackerven
Copy link
Contributor Author

Through the documentation I know how to replace it with my own fontawesome link. But the above problem remains unresolved.

Strangely, I tried to modify the class attribute in the browser and it successfully displayed.
image

image

@Mister-Hope
Copy link
Member

We provide iconPrefix options, you should try to override it to empty string, then add full icon class in your config.

@Mister-Hope
Copy link
Member

Due to the iconPrefix is different I think I do make a good choice for the default value with fas fa- prefix and free sets.

If you do need brand or pro icons as well, set your own link and override to '' for prefix.

@Mister-Hope Mister-Hope closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
@Ackerven
Copy link
Contributor Author

Thanks! It worked.

By the way, if iconPrefix is set to '', it will still add a prefix.

Need to write an empty character, such as ' '.

@Mister-Hope
Copy link
Member

Then that should be a bug

@Mister-Hope Mister-Hope reopened this Jul 28, 2022
@Mister-Hope Mister-Hope changed the title [Feature Request]add more fontawesome icons [Bug] Setting iconPrefix to '' don't work Aug 1, 2022
@Mister-Hope Mister-Hope added bug Something isn't working and removed enhancement New feature or request labels Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants