feat(plugin-external-link-icon): add locales option #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorlxy
requested changes
Jan 18, 2022
| * Enable @vuepress/plugin-external-link-icon or not | ||
| */ | ||
| externalLinkIcon?: boolean | ||
| externalLinkIcon?: ExternalLinkIconPluginOptions | boolean |
Member
There was a problem hiding this comment.
I'd prefer to keep themePlugins consistent, i.e. keep externalLinkIcon?: boolean here.
We can still keep the openInNewWindow locale config, and use a resolveExternalLinkIconPluginOptions util to resolve the options.
| /** | ||
| * i18n config | ||
| */ | ||
| i18n: Record<string, string> |
Member
There was a problem hiding this comment.
Keep consistent with other plugins like plugin-pwa-popup or plugin-search.
locales?: LocaleConfig<{
openInNewWindow: string
}>
meteorlxy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.