docs: add pnpm docs #929
Merged
docs: add pnpm docs #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorlxy
requested changes
Jun 6, 2022
meteorlxy
requested changes
Jun 7, 2022
Mister-Hope
commented
Oct 19, 2022
Contributor
|
Might be worth merge it? upd. I think the order should be: npm, pnpm, yarn. This seems more logical. |
Mister-Hope
commented
Nov 7, 2022
Member
Author
pnpm takes less time during install comparing to npm. so we do recommand people to use pnpm as first choise. |
Member
|
We may also need to update the deployment guide to use pnpm as recommendation |
Member
Author
|
Done @meteorlxy |
meteorlxy
reviewed
Dec 7, 2022
meteorlxy
reviewed
Dec 7, 2022
meteorlxy
reviewed
Dec 7, 2022
meteorlxy
reviewed
Dec 7, 2022
Member
Author
|
Done |
meteorlxy
requested changes
Dec 8, 2022
docs/guide/deployment.md
Outdated
| ``` | ||
|
|
||
| 3. After running `yarn docs:build`, deploy using the command `firebase deploy`. | ||
| 3. After running `pnpm docs:build` `yarn docs:build` or `npm run docs:build`, deploy using the command `firebase deploy`. |
Member
There was a problem hiding this comment.
No need to mention yarn & npm based on the assumption
docs/guide/deployment.md
Outdated
|
|
||
| - **Build Command:** `yarn docs:build` | ||
| - **Publish directory:** `docs/.vuepress/dist` | ||
| - **Build Command:** `npm i -g pnpm@7 && pnpm docs:build` |
Member
There was a problem hiding this comment.
Is it necessary to add @7 for pnpm? If not, we'd better remove it so we don't need to update it in the future
docs/zh/guide/deployment.md
Outdated
| ``` | ||
|
|
||
| 3. 在执行了 `yarn docs:build` 或 `npm run docs:build` 后, 使用 `firebase deploy` 指令来部署。 | ||
| 3. 在执行了 `pnpm docs:build`, `yarn docs:build` 或 `npm run docs:build` 后, 使用 `firebase deploy` 指令来部署。 |
docs/zh/guide/deployment.md
Outdated
|
|
||
| - **Build Command:** `yarn docs:build` | ||
| - **Publish directory:** `docs/.vuepress/dist` | ||
| - **Build Command:** `npm i -g pnpm@7 && pnpm docs:build` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.