We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
There will be noob users who set titles like this, and page.title (with string type) will have other types, and this may break the application.
Unless we set page.title: unknown , we should guard the types of it.
The text was updated successfully, but these errors were encountered:
fix(core): ensure page.title isString, close #1306
It's too verbose to use Record<string, unknown> for all frontmatter properties. We'd better assume that user use it correctly.
BTW, does title: 1 result in number or string?
Sorry, something went wrong.
number, so that's why I want this. No trim, replace or other functions are on numbers, so an errror will be thrown while it bypass typescript checks.
I agree it's fine for us not to check other properties, but title is an important one, and it's extracted just into page object (so you realize this is important)
I alrady met 10+ reports about setting title to a non-syring value by mistake and got error
fix(core): ensure page.title isString (close #1306) (#1308)
Successfully merging a pull request may close this issue.