Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code): highlighted lines were not highlighted #37

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@Kocal
Copy link
Contributor

Kocal commented Jan 8, 2020

In code block, highlighted lines (ex: when using yaml{4-6} to higlight lines 4 to 6) were not highlighted because it was black on black.

What do you think?

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:
before:
Sélection_999(506)

after:
Sélection_999(507)

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 78.0.3904.108
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Kocal Kocal mentioned this pull request Jan 8, 2020
6 of 18 tasks complete
@newsbielt703

This comment has been minimized.

Copy link
Member

newsbielt703 commented Jan 8, 2020

It might be copied from VP's default theme.

Copy link
Member

newsbielt703 left a comment

LGTM.

@newsbielt703 newsbielt703 merged commit 377be90 into vuepressjs:master Jan 8, 2020
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@Kocal Kocal deleted the Kocal:fix/code-highlight branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.