Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(fonts) use font-display swap to prevent FOIT #71

Merged
merged 2 commits into from Mar 9, 2020

Conversation

@Kocal
Copy link
Contributor

Kocal commented Mar 8, 2020

Summary

When the custom font PT Serif is downloading, headings are not visible until the custom font is downloaded.
This is what we call Flash Of Invisible Text (FOIT).

To prevent this, we cant set @font-display: swap to:

  • use the fallback font when PT Serif is being downloaded
  • use PT Serif when it's downloaded

This is called Flash on Unstyled Text (FOUT), and it's preferable over FOIT since you can directly see the content.

Read more at: https://css-tricks.com/font-display-masses/

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 80.0.3987.116
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

newsbielt703 left a comment

LGTM!

@newsbielt703 newsbielt703 merged commit a9c6cd5 into vuepressjs:master Mar 9, 2020
0 of 5 checks passed
0 of 5 checks passed
Header rules Deploy failed
Details
Mixed content Deploy failed
Details
Pages changed Deploy failed
Details
Redirect rules Deploy failed
Details
deploy/netlify Deploy preview failed.
Details
@Kocal Kocal deleted the Kocal:imp/font-loading branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.