Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: category page filters are take off after using pagination #1093

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 3, 2022

Description

Filters are not taken off after when using pagination on the category page.

Motivation and Context

Bugfix

How Has This Been Tested?

  1. Go to Category Page (can be main or for given product type) - i. e. https://demo-magento2-dev.europe-west1.gcp.storefrontcloud.io/default/c/women/tops-women/jackets-women.html
  2. Setup filter/category which should return > 10 products - i. e. Solid.
  3. Hit Apply filters.
  4. Switch to the second page of listed products.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo added this to the 1.0.0-rc.9 milestone Jun 3, 2022
@bartoszherba bartoszherba merged commit 0baddfb into develop Jun 3, 2022
@bartoszherba bartoszherba deleted the M2-606-category-page-filters-are-taken-off-after-going-to-next-page-of branch June 3, 2022 11:02
@Frodigo Frodigo changed the title fix: m2-606. category page filters are take off after using pagination fix: category page filters are take off after using pagination Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants