From 271be339f8ebce4818e0450c20372d40cd6781bc Mon Sep 17 00:00:00 2001 From: Aditya Sharma Date: Mon, 26 Aug 2019 12:58:09 +0530 Subject: [PATCH 1/5] Done: Remove index value not_analyzed for some fields as it is deprecated #334 As of 5.0 value not_analyzed is no longer applicable. Reference: https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_mapping_changes.html#_literal_index_literal_property Citation: On all field datatypes (except for the deprecated string field), the index property now only accepts true/false instead of not_analyzed/no. The string field still accepts analyzed/not_analyzed/no. As per https://www.elastic.co/guide/en/elasticsearch/reference/1.4/mapping-core-types.html, not_analyzed means that its still searchable, but does not go through any analysis process or broken down into tokens. As per https://www.elastic.co/guide/en/elasticsearch/reference/current/text.html, index means Should the field be searchable? Accepts true (default) or false. So, changing index value not_analyzed to true. We can also remove index key as default value is true, but as I am unsure how it works when migrating to new release with schema changes. Setting it true as it may cause no harm and produces desired results --- config/elastic.schema.attribute.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/elastic.schema.attribute.json b/config/elastic.schema.attribute.json index aae5807f..6edbabd6 100644 --- a/config/elastic.schema.attribute.json +++ b/config/elastic.schema.attribute.json @@ -10,9 +10,9 @@ "properties": { "value": { "type": "text", - "index": "not_analyzed" + "index": true } } } } -} \ No newline at end of file +} From cea9c5ed3cf11a7e7f7d09fd4408ab0396146940 Mon Sep 17 00:00:00 2001 From: Aditya Sharma Date: Fri, 30 Aug 2019 17:55:56 +0530 Subject: [PATCH 2/5] Updated: changelog with index property value change #334 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5b85cef5..433f46ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Sharp dependency has been updated. *It might require reinstalling yarn dependencies* - @lukeromanowicz +- Replaced index property value `not_analyzed` with `true` for `options` field in attribute schema - @adityasharma7 (#334) ### Fixed - Missing `res` and `req` parameters are now passed to ProductProcessor - @jahvi (#218) From 233d41a8bba8d3c081eb1d56441b596037be476c Mon Sep 17 00:00:00 2001 From: haelbichalex Date: Tue, 3 Sep 2019 10:07:14 +0200 Subject: [PATCH 3/5] =?UTF-8?q?Update=20README.md=20=E2=80=93=20Node=2010.?= =?UTF-8?q?x=20is=20now=20required?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1c6027ba..acf7523e 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ Besides a big improvement for the shopping experience, we also want to create a - Docker and Docker Compose Already included in `vue-storefront-api` Docker image (required locally, if you do not use containerization): -- Node.js 8.x or higher +- Node.js 10.x or higher - Yarn ## Installation From 7d5ae07a3cbaa24ac5cd4f5baefdb514c53da118 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandra=20Perko-Klomfa=C3=9F?= Date: Fri, 25 Oct 2019 01:33:51 +0200 Subject: [PATCH 4/5] Typo in README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index acf7523e..bb2df976 100644 --- a/README.md +++ b/README.md @@ -82,7 +82,7 @@ This backend is using ElasticSearch data formats popularized by [ElasticSuite fo Please use data migration mechanism provided to manipulate Redis, ElasticSearch or kue. Details: https://github.com/DivanteLtd/vue-storefront-api/tree/master/doc ## Adding custom modules with own dependencies (Yarn only) -When adding custom [Extensions to the API](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/Extending%20vue-storefront-api.md) you might want to define some dependencies inside them. Thanks to [Yarn workspaces](https://yarnpkg.com/lang/en/docs/workspaces/) dependecies defined inside your custom module will be intaled when you execute `yarn` at project root level, so it's way esier and faster than installing all modules dependcies separetly. +When adding custom [Extensions to the API](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/Extending%20vue-storefront-api.md) you might want to define some dependencies inside them. Thanks to [Yarn workspaces](https://yarnpkg.com/lang/en/docs/workspaces/) dependencies defined inside your custom module will be installed when you execute `yarn` at project root level, so it's way easier and faster than installing all modules dependencies separately. To do this, define the `package.json` with your dependencies in your custom module: - `src/api/extensions/{your-custom-extension}/package.json` From f64b58dee9dabe0f192f649605691200bc1440c7 Mon Sep 17 00:00:00 2001 From: Kevin Gimbel Date: Wed, 6 Nov 2019 10:16:46 +0100 Subject: [PATCH 5/5] Remove default user and password from default.json This commit removes the user and password from `config/default.json`. This allows to not set a username and password when connecting to Elasticsearch; Previously the default values were used if username and password were omitted from `config/local.json` Fixes #358 Signed-off-by: Kevin Gimbel --- config/default.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/default.json b/config/default.json index 586be40a..990271cd 100644 --- a/config/default.json +++ b/config/default.json @@ -14,8 +14,6 @@ "host": "localhost", "port": 9200, "protocol": "http", - "user": "elastic", - "password": "changeme", "min_score": 0.01, "indices": [ "vue_storefront_catalog",