From ddc0901889c8d55fc1293e74bba0bb84a295e741 Mon Sep 17 00:00:00 2001 From: ResuBaka Date: Fri, 4 Oct 2019 16:30:43 +0200 Subject: [PATCH 1/5] Changed pre commit linting to use production linting This is done so you don't commit with debugger statements in it. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a681cade98..098e5b0c6f 100755 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "lerna": "lerna" }, "lint-staged": { - "*.{js,vue,ts}": "eslint", + "*.{js,vue,ts}": "cross-env NODE_ENV=production eslint", "**/i18n/*.csv": ["node ./core/scripts/utils/sort-translations.js", "git add"] }, "husky": { From c9542c0a74e30d274c77610cbedcad5b00a364a3 Mon Sep 17 00:00:00 2001 From: ResuBaka Date: Fri, 4 Oct 2019 16:35:21 +0200 Subject: [PATCH 2/5] Update CHANGELOG.md --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c64949d845..34c2874251 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [1.11.0-rc.2] - unreleased + +### Added + +- Changed pre commit hook to use NODE_ENV production to check for debugger statements - @resubaka (#3686) + ## [1.11.0-rc.1] - 2019.10.03 ### Added From 7f12e846404b9dd525e355a80cff9b2869bb0130 Mon Sep 17 00:00:00 2001 From: ResuBaka Date: Fri, 4 Oct 2019 16:36:25 +0200 Subject: [PATCH 3/5] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 34c2874251..d1cb30e93d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [1.11.0-rc.2] - unreleased -### Added +### Changed / Improved - Changed pre commit hook to use NODE_ENV production to check for debugger statements - @resubaka (#3686) From ac69013a956cd5d4c71c6afb59e87d90778c5abc Mon Sep 17 00:00:00 2001 From: ResuBaka Date: Thu, 10 Oct 2019 15:39:53 +0200 Subject: [PATCH 4/5] Added cross-env NODE_ENV=production to the linting --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 098e5b0c6f..d4ae7176f1 100755 --- a/package.json +++ b/package.json @@ -45,7 +45,7 @@ "test:unit:watch": "jest -c test/unit/jest.conf.js --watch", "test:e2e": "cypress open", "test:e2e:ci": "cypress run", - "lint": "eslint --ext .js,.vue,.ts core src --fix", + "lint": "cross-env NODE_ENV=production eslint --ext .js,.vue,.ts core src --fix", "lerna": "lerna" }, "lint-staged": { From 96731d8e339e780321d394f139cb6ff1db171759 Mon Sep 17 00:00:00 2001 From: Patryk Andrzejewski Date: Wed, 20 Nov 2019 15:27:28 +0100 Subject: [PATCH 5/5] Update CHANGELOG.md --- CHANGELOG.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 776a36af74..f93609f772 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Redirect from simple product using url_path - @benjick (#3804) - Mount app in 'beforeResolve' if it's not dispatched in 'onReady' - @gibkigonzo (#3669) +### Changed / Improved +- Changed pre commit hook to use NODE_ENV production to check for debugger statements - @resubaka (#3686) + ## [1.11.0-rc.2] - 2019.10.31 ### Added @@ -64,10 +67,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed / Improved - Use `encodeURIComponent` to encode get parameters in `multimatch.js` - @adityasharma7 (#3736) -### Changed / Improved - -- Changed pre commit hook to use NODE_ENV production to check for debugger statements - @resubaka (#3686) - ## [1.11.0-rc.1] - 2019.10.03 ### Added