From 85dd75e1e046c2a3eddbe7f9c03c4208c3733697 Mon Sep 17 00:00:00 2001 From: Kacper Malkowski Date: Tue, 16 Mar 2021 21:34:32 +0100 Subject: [PATCH 1/2] remove helpers/filters from nuxt-theme and commercetools --- .../theme/helpers/filters/getFiltersForUrl.js | 6 ------ .../helpers/filters/getFiltersFromUrl.js | 19 ------------------- .../theme/helpers/filters/getFiltersForUrl.js | 4 ---- .../helpers/filters/getFiltersFromUrl.js | 4 ---- .../theme/helpers/filters/index.js | 4 ---- 5 files changed, 37 deletions(-) delete mode 100644 packages/commercetools/theme/helpers/filters/getFiltersForUrl.js delete mode 100644 packages/commercetools/theme/helpers/filters/getFiltersFromUrl.js delete mode 100644 packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersForUrl.js delete mode 100644 packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersFromUrl.js delete mode 100644 packages/core/nuxt-theme-module/theme/helpers/filters/index.js diff --git a/packages/commercetools/theme/helpers/filters/getFiltersForUrl.js b/packages/commercetools/theme/helpers/filters/getFiltersForUrl.js deleted file mode 100644 index 2fb1ec3862..0000000000 --- a/packages/commercetools/theme/helpers/filters/getFiltersForUrl.js +++ /dev/null @@ -1,6 +0,0 @@ -export const getFiltersForUrl = (filters) => { - return Object.entries(filters || {}).reduce((prev, [name, filter]) => { - prev[name] = filter.options.filter(option => option.selected).map(option => option.value); - return prev; - }, {}); -}; diff --git a/packages/commercetools/theme/helpers/filters/getFiltersFromUrl.js b/packages/commercetools/theme/helpers/filters/getFiltersFromUrl.js deleted file mode 100644 index 10702d8ab2..0000000000 --- a/packages/commercetools/theme/helpers/filters/getFiltersFromUrl.js +++ /dev/null @@ -1,19 +0,0 @@ -export const getFiltersFromUrl = (context, filters) => { - const { query } = context.root.$route; - const filtersFromQuery = Object.entries(query).filter(([name]) => !['page', 'items'].includes(name)); - filtersFromQuery.forEach(([name, values]) => { - if (!filters[name]) { - return; - } - - if (!Array.isArray(values)) { - values = [values]; - } - filters[name].options.forEach(option => { - if (values.includes(option.value)) { - option.selected = true; - } - }); - }); - return filters; -}; diff --git a/packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersForUrl.js b/packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersForUrl.js deleted file mode 100644 index 3fb050aed5..0000000000 --- a/packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersForUrl.js +++ /dev/null @@ -1,4 +0,0 @@ -export const getFiltersForUrl = (filters) => { - console.warn('Please implement this per integration'); - return filters; -}; diff --git a/packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersFromUrl.js b/packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersFromUrl.js deleted file mode 100644 index 811e68ce64..0000000000 --- a/packages/core/nuxt-theme-module/theme/helpers/filters/getFiltersFromUrl.js +++ /dev/null @@ -1,4 +0,0 @@ -export const getFiltersFromUrl = (context, filters) => { - console.warn('Please implement this per integration'); - return filters; -}; diff --git a/packages/core/nuxt-theme-module/theme/helpers/filters/index.js b/packages/core/nuxt-theme-module/theme/helpers/filters/index.js deleted file mode 100644 index 93280e4a6c..0000000000 --- a/packages/core/nuxt-theme-module/theme/helpers/filters/index.js +++ /dev/null @@ -1,4 +0,0 @@ -// TODO: remove, use faceting instead - -export { getFiltersFromUrl } from './getFiltersFromUrl'; -export { getFiltersForUrl } from './getFiltersForUrl'; From 5f855703d111305d4a0fed7d5c596d4b85d89363 Mon Sep 17 00:00:00 2001 From: Kacper Malkowski Date: Thu, 18 Mar 2021 16:26:43 +0100 Subject: [PATCH 2/2] add changelog for #5620 issue --- packages/core/docs/changelog/5620.js | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 packages/core/docs/changelog/5620.js diff --git a/packages/core/docs/changelog/5620.js b/packages/core/docs/changelog/5620.js new file mode 100644 index 0000000000..ee74d9ff80 --- /dev/null +++ b/packages/core/docs/changelog/5620.js @@ -0,0 +1,8 @@ +module.exports = { + description: 'removed helpers/filters from @vue-storefront/nuxt-theme and @vue-storefront/commercetools-theme because they are useless now', + link: 'https://github.com/vuestorefront/vue-storefront/issues/5620', + isBreaking: false, + breakingChanges: [], + author: 'Kacper Małkowski', + linkToGitHubAccount: 'https://github.com/porithe/' +};