-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Next: Login & Registration form error/success handling and validation #5724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 708337237Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
💙 vsf-next-demo successfully deployed at |
09d4901 to
8e6586e
Compare
d0f9cc0 to
c941837
Compare
94bb752 to
7eccac9
Compare
|
solve conflicts please |
7eccac9 to
ee260c5
Compare
|
@andrzejewsky conflicts resolved |
ee260c5 to
d50d3fb
Compare
13c50f8 to
c3dc554
Compare
c3dc554 to
9ed2698
Compare
9ed2698 to
b5f4ddc
Compare
|
This is closed due to inactivity. If you want your PR to be re-opened, please update your files, check for any conflicts. If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1 |
Related Issues
closes #5377
Short Description of the PR
AuthModalcomponent and splittedLoginModalcomponent toLoginFormandRegisterForm.isLoginModalandtoggleLoginModaltoisAuthModalandtoggleAuthModalScreenshots of Visual Changes before/after (if There Are Any)
Desktop:
https://user-images.githubusercontent.com/40273258/113286914-1c9eb680-92ed-11eb-9e05-5e0e87736225.mp4
Mobile:
https://user-images.githubusercontent.com/40273258/113286961-32ac7700-92ed-11eb-803c-aec2ad6a986c.mp4
Pull Request Checklist