Skip to content

Conversation

@lukaszjedrasik
Copy link
Contributor

Related Issues

closes #5377

Short Description of the PR

  • Added VSF Error handling to display errors in Login/Registration forms.
  • Added AuthModal component and splittedLoginModal component to LoginForm and RegisterForm.
  • Changed isLoginModal and toggleLoginModal to isAuthModal and toggleAuthModal

Screenshots of Visual Changes before/after (if There Are Any)

Desktop:
https://user-images.githubusercontent.com/40273258/113286914-1c9eb680-92ed-11eb-9e05-5e0e87736225.mp4

Mobile:
https://user-images.githubusercontent.com/40273258/113286961-32ac7700-92ed-11eb-803c-aec2ad6a986c.mp4

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

@lukaszjedrasik lukaszjedrasik added the Next Issues/bugs for Vue Storefront Next label Apr 1, 2021
@coveralls
Copy link

coveralls commented Apr 1, 2021

Pull Request Test Coverage Report for Build 708337237

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.596%

Totals Coverage Status
Change from base Build 707829881: 0.0%
Covered Lines: 1506
Relevant Lines: 1755

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

💙 vsf-next-demo successfully deployed at

@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch 2 times, most recently from d0f9cc0 to c941837 Compare April 15, 2021 11:45
@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch 2 times, most recently from 94bb752 to 7eccac9 Compare April 16, 2021 11:48
@andrzejewsky
Copy link
Contributor

solve conflicts please

@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch from 7eccac9 to ee260c5 Compare April 29, 2021 14:14
@github-actions github-actions bot added commercetools core docs Tasks regarding documentation labels Apr 29, 2021
@lukaszjedrasik
Copy link
Contributor Author

@andrzejewsky conflicts resolved

@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch from ee260c5 to d50d3fb Compare May 4, 2021 06:23
@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch 2 times, most recently from 13c50f8 to c3dc554 Compare May 20, 2021 08:50
@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch from c3dc554 to 9ed2698 Compare May 26, 2021 08:25
@lukaszjedrasik lukaszjedrasik force-pushed the register-login-err-handling branch from 9ed2698 to b5f4ddc Compare June 8, 2021 06:13
@bloodf
Copy link
Contributor

bloodf commented Aug 31, 2021

This is closed due to inactivity.

If you want your PR to be re-opened, please update your files, check for any conflicts.

If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1

@bloodf bloodf closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commercetools core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login & Registration form error/success handling and validation

5 participants