Skip to content

Conversation

@WojtekTheWebDev
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds moduleFromEndpoints to nuxt and next storefront packages.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@WojtekTheWebDev WojtekTheWebDev requested a review from a team as a code owner February 26, 2024 13:58
@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: 25678bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WojtekTheWebDev WojtekTheWebDev marked this pull request as draft February 26, 2024 13:58
@WojtekTheWebDev WojtekTheWebDev marked this pull request as ready for review February 29, 2024 13:03
WojtekTheWebDev and others added 5 commits February 29, 2024 15:18
…ints.spec.ts

Co-authored-by: Tomasz GΓ³ral <tomasz.gl69@gmail.com>
* feat: default behaviour of HTTP Client

* remove isomorphic-fetch from depts

* full implementation of HTTP client

* test: update tests based on the review

* fix issue with URL class and urls as paths

* add test for axios

* add computed headers to http client

* update tsdocs
* feat: default behaviour of HTTP Client

* remove isomorphic-fetch from depts

* full implementation of HTTP client

* feat: add customizable error handler

* await error handler

* update error handler due to feedback

* update tsdocs

* refactor default http client

* use unknown instead of any

* add method name to error handler

* update tsdocs

* apply review suggestions
* feat: default behaviour of HTTP Client

* remove isomorphic-fetch from depts

* full implementation of HTTP client

* feat: add customizable error handler

* await error handler

* refactor: improve tsdocs

* test non-object params

* add comment

* add module types to api extractor
* feat: default behaviour of HTTP Client

* remove isomorphic-fetch from depts

* full implementation of HTTP client

* feat: add customizable error handler

* await error handler

* refactor: improve tsdocs

* fix: issue with custom methods in new module

* test: additonal tests

* fix issue with losing tsdocs

* rename file

* missing import

* include credentials

* Update packages/sdk/src/modules/moduleFromEndpoints/types.ts

Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com>

---------

Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com>
@WojtekTheWebDev WojtekTheWebDev changed the title feat: add moduleFromEndpoints to nuxt and next storefront packages feat: add middlewareModule to nuxt and next storefront packages Mar 11, 2024
@WojtekTheWebDev WojtekTheWebDev requested a review from jagoral March 11, 2024 15:21
Base automatically changed from feat/moduleFromEndpoints to main March 11, 2024 15:38
@WojtekTheWebDev WojtekTheWebDev requested a review from jagoral March 12, 2024 09:01
@WojtekTheWebDev WojtekTheWebDev merged commit 27826fc into main Mar 12, 2024
@WojtekTheWebDev WojtekTheWebDev deleted the chore/in-3860-nuxt-and-next branch March 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants