From f79480e380ab17a32c714e663b5d4b7aa0f961b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20G=C3=B3ral?= Date: Thu, 12 Dec 2024 21:09:28 +0700 Subject: [PATCH] fix: default error handler type --- .changeset/modern-comics-impress.md | 5 +++++ .../middleware/src/errors/defaultErrorHandler.ts | 8 ++------ packages/middleware/src/types/common.ts | 12 +++++++----- 3 files changed, 14 insertions(+), 11 deletions(-) create mode 100644 .changeset/modern-comics-impress.md diff --git a/.changeset/modern-comics-impress.md b/.changeset/modern-comics-impress.md new file mode 100644 index 0000000000..f1f874a137 --- /dev/null +++ b/.changeset/modern-comics-impress.md @@ -0,0 +1,5 @@ +--- +"@vue-storefront/middleware": patch +--- + +**[FIXED]** type of `defaultErrorHandler` diff --git a/packages/middleware/src/errors/defaultErrorHandler.ts b/packages/middleware/src/errors/defaultErrorHandler.ts index 006d4a7168..29ec1c7372 100644 --- a/packages/middleware/src/errors/defaultErrorHandler.ts +++ b/packages/middleware/src/errors/defaultErrorHandler.ts @@ -1,14 +1,10 @@ import { getAgnosticStatusCode } from "../helpers"; -import type { Integration } from "../types"; +import type { ErrorHandler } from "../types"; /** * Default error handler for the middleware */ -export const defaultErrorHandler: Integration["errorHandler"] = ( - error, - _req, - res -) => { +export const defaultErrorHandler: ErrorHandler = (error, _req, res) => { const status = getAgnosticStatusCode(error); res.status(status); if (status < 500) { diff --git a/packages/middleware/src/types/common.ts b/packages/middleware/src/types/common.ts index 0dba3ec1fc..fb72c9b51b 100644 --- a/packages/middleware/src/types/common.ts +++ b/packages/middleware/src/types/common.ts @@ -111,6 +111,12 @@ export interface ApiClientExtension { ) => ApiClientExtensionHooks; } +export type ErrorHandler = ( + error: unknown, + req: AlokaiRequest, + res: AlokaiResponse +) => void; + export interface Integration< CONFIG extends TObject = any, API extends ApiMethods = any, @@ -162,11 +168,7 @@ export interface Integration< * }; * ``` */ - errorHandler?: ( - error: unknown, - req: AlokaiRequest, - res: AlokaiResponse - ) => void; + errorHandler?: ErrorHandler; } export interface RequestParams {