From fcee320fbf0a7c33908d18b750e15a7ee4aea696 Mon Sep 17 00:00:00 2001 From: Adam Marcinkowski Date: Sat, 24 Feb 2018 17:57:48 +0100 Subject: [PATCH 01/15] [#639] Set color lists, prepare new mixin to generate selectors --- src/themes/default/css/base/_color.scss | 9 ++- src/themes/default/css/base/_global_vars.scss | 4 +- src/themes/default/css/helpers/_mixins.scss | 3 + .../css/helpers/mixins/_color-selectors.scss | 33 +++++++++++ src/themes/default/css/main.scss | 2 + src/themes/default/css/variables/_colors.scss | 56 +++++++++++++++++++ .../default/css/variables/_variables.scss | 5 ++ 7 files changed, 110 insertions(+), 2 deletions(-) create mode 100644 src/themes/default/css/helpers/_mixins.scss create mode 100644 src/themes/default/css/helpers/mixins/_color-selectors.scss create mode 100644 src/themes/default/css/variables/_colors.scss create mode 100644 src/themes/default/css/variables/_variables.scss diff --git a/src/themes/default/css/base/_color.scss b/src/themes/default/css/base/_color.scss index 4405ff0dc9..247c407183 100644 --- a/src/themes/default/css/base/_color.scss +++ b/src/themes/default/css/base/_color.scss @@ -11,4 +11,11 @@ } } -@include color; +@include color; // @todo remove after refactore + +// Generate colors selectors .cl-{#name-of-color} +@include color-selectors(map_merge($colors, $colors-basic), 'cl', 'color'); + +// Generate background-color selectors .bg-{#name-of-color} +@include color-selectors($colors-background, 'bg', 'background-color'); +@include color-selectors($colors, 'bg-cl', 'background-color'); diff --git a/src/themes/default/css/base/_global_vars.scss b/src/themes/default/css/base/_global_vars.scss index 378408ee7f..968ef72f77 100644 --- a/src/themes/default/css/base/_global_vars.scss +++ b/src/themes/default/css/base/_global_vars.scss @@ -1,8 +1,9 @@ // Add new colors to the BOTTOM of the list, it's very important! +// @todo remove after refactore $colors: ( white: #FFFFFF, black: #000000, - gray: #8E8E8E, + sgray: #8E8E8E, lightgray: #F2F2F2, darkgray: #333333, alto: #E0E0E0, @@ -18,6 +19,7 @@ $colors: ( //@to-do make it more customizable - change colors to match their usage not color name so other people can customize it when creatign own theme +// @todo move to separate file $z-index: ( modal: 10, notification: 1000, diff --git a/src/themes/default/css/helpers/_mixins.scss b/src/themes/default/css/helpers/_mixins.scss new file mode 100644 index 0000000000..03c91646e7 --- /dev/null +++ b/src/themes/default/css/helpers/_mixins.scss @@ -0,0 +1,3 @@ +// Global mixins +// ============= +@import 'mixins/color-selectors' diff --git a/src/themes/default/css/helpers/mixins/_color-selectors.scss b/src/themes/default/css/helpers/mixins/_color-selectors.scss new file mode 100644 index 0000000000..11d54da83a --- /dev/null +++ b/src/themes/default/css/helpers/mixins/_color-selectors.scss @@ -0,0 +1,33 @@ +/// Generate colors values +/// @name color-selectors +/// @param {Map} $map [$colors] - Map with color values +/// @param {String} $selector ['.cl'] - Selector to css class, .#{$selector}-#{$name-of-color} +/// @param {String} $property ['color'] - CSS property +@mixin color-selectors($map: $colors, $selector: 'cl', $property: 'color') { + @each $name, $value in $map { + // in case when color value is map with hover, focus variants + @if type-of($value) == map { + @if map_has_key($value, default) { + .#{$selector}-#{$name} { + #{$property}: map-get($value, default); + } + } + + @if map_has_key($value, hover) { + .\:#{$selector}-#{$name}:hover { + #{$property}: map-get($value, hover); + } + } + + @if map_has_key($value, focus) { + .\:#{$selector}-#{$name}:focus { + #{$property}: map-get($value, focus); + } + } + } @else { + .#{$selector}-#{$name} { + #{$property}: #{$value}; + } + } + } +} diff --git a/src/themes/default/css/main.scss b/src/themes/default/css/main.scss index b2ae14cda2..2596428db6 100644 --- a/src/themes/default/css/main.scss +++ b/src/themes/default/css/main.scss @@ -1,4 +1,6 @@ // Base +@import 'variables/variables'; +@import 'helpers/mixins'; @import 'base/base'; @import 'base/flexbox-grid'; @import 'base/global_vars'; diff --git a/src/themes/default/css/variables/_colors.scss b/src/themes/default/css/variables/_colors.scss new file mode 100644 index 0000000000..0e9624b1e2 --- /dev/null +++ b/src/themes/default/css/variables/_colors.scss @@ -0,0 +1,56 @@ +// Colors +// ====== +// @LandonSchropp's approach of naming color variables. +// - http://davidwalsh.name/sass-color-variables-dont-suck +// - http://www.color-blindness.com/color-name-hue/ + +// General colors palette +$colors: ( + transparent: transparent, + black: #000, + white: #fff, + white-smoke: #f2f2f2, // lightgray @todo remove these comments after refactore + gainsboro: #e0e0e0, // alto + silver: #bdbdbd, // lightgray-secondary + gray: #828282, // gray-secondary + suva-gray: #8e8e8e, // gray + matterhorn: #4f4f4f, // emperor + night-rider: #333, // darkgray + burnt-sienna: #eb5757, // red + buccaneer: #755, // russet + forest-green: #308c14, // la-palma + puerto-rico: #4dba87 // ocean-green +); + +// Theme generic colors +// Key: name of color +// Value: color value or map with default, hover, focus color values +$colors-basic: ( + primary: ( + default: map-get($colors, matterhorn), + hover: map-get($colors, night-rider) + ), + secondary: ( + default: map-get($colors, gray), + hover: map-get($colors, matterhorn), + ), + accent: ( + default: map-get($colors, night-rider), + hover: map-get($colors, black), + ), + error: map-get($colors, burnt-sienna), + success: map-get($colors, puerto-rico) +); + +// Theme generic background colors +$colors-background: ( + primary: ( + default: map-get($colors, white), + hover: map-get($colors, silver) + ), + secondary: ( + default: map-get($colors, white-smoke), + hover: map-get($colors, gainsboro) + ) +); + diff --git a/src/themes/default/css/variables/_variables.scss b/src/themes/default/css/variables/_variables.scss new file mode 100644 index 0000000000..1a5baa0a5f --- /dev/null +++ b/src/themes/default/css/variables/_variables.scss @@ -0,0 +1,5 @@ +// Default theme variables +// ======================= + +// Colors +@import 'colors'; From 4cecb3d4043480e0c6a4959a2fccf0f9cb1c407c Mon Sep 17 00:00:00 2001 From: Adam Marcinkowski Date: Sun, 25 Feb 2018 17:38:36 +0100 Subject: [PATCH 02/15] [#639] Prepare colors list to refactore --- src/themes/default/css/base/_color.scss | 5 ++-- src/themes/default/css/layout/_border.scss | 6 +---- src/themes/default/css/variables/_colors.scss | 27 +++++++++---------- 3 files changed, 16 insertions(+), 22 deletions(-) diff --git a/src/themes/default/css/base/_color.scss b/src/themes/default/css/base/_color.scss index 247c407183..078ae1cf19 100644 --- a/src/themes/default/css/base/_color.scss +++ b/src/themes/default/css/base/_color.scss @@ -14,8 +14,7 @@ @include color; // @todo remove after refactore // Generate colors selectors .cl-{#name-of-color} -@include color-selectors(map_merge($colors, $colors-basic), 'cl', 'color'); +@include color-selectors(map_merge($_colors, $colors-basic), 'cl', 'color'); // Generate background-color selectors .bg-{#name-of-color} -@include color-selectors($colors-background, 'bg', 'background-color'); -@include color-selectors($colors, 'bg-cl', 'background-color'); +@include color-selectors(map_merge($_colors, $colors-basic), 'bg', 'background-color'); diff --git a/src/themes/default/css/layout/_border.scss b/src/themes/default/css/layout/_border.scss index 1b993cf598..5f5f1d270f 100644 --- a/src/themes/default/css/layout/_border.scss +++ b/src/themes/default/css/layout/_border.scss @@ -21,16 +21,12 @@ $border-radius: ( border-bottom-style: solid; } } - @each $color, $colorcode in $colors { - .brdr-c-#{$color} { - border-color: #{$colorcode}; - } - } @each $name, $value in $border-radius { .brdr-#{$name} { border-radius: #{$value}; } } + @include color-selectors(map_merge($_colors, $colors-basic), 'brdr-cl', 'border-color'); } .brdr-none { diff --git a/src/themes/default/css/variables/_colors.scss b/src/themes/default/css/variables/_colors.scss index 0e9624b1e2..a77baa12a9 100644 --- a/src/themes/default/css/variables/_colors.scss +++ b/src/themes/default/css/variables/_colors.scss @@ -5,7 +5,7 @@ // - http://www.color-blindness.com/color-name-hue/ // General colors palette -$colors: ( +$_colors: ( // @todo change $_colors to $color after refactore transparent: transparent, black: #000, white: #fff, @@ -22,6 +22,8 @@ $colors: ( puerto-rico: #4dba87 // ocean-green ); +$colors: $_colors; // @todo remove if after refactore + // Theme generic colors // Key: name of color // Value: color value or map with default, hover, focus color values @@ -34,6 +36,16 @@ $colors-basic: ( default: map-get($colors, gray), hover: map-get($colors, matterhorn), ), + bg-primary: ( + default: map-get($colors, white), + hover: map-get($colors, silver) + ), + bg-secondary: ( + default: map-get($colors, white-smoke), + hover: map-get($colors, gainsboro) + ), + brdr-primary: map-get($colors, silver), + brdr-secondary: map-get($colors, gainsboro), accent: ( default: map-get($colors, night-rider), hover: map-get($colors, black), @@ -41,16 +53,3 @@ $colors-basic: ( error: map-get($colors, burnt-sienna), success: map-get($colors, puerto-rico) ); - -// Theme generic background colors -$colors-background: ( - primary: ( - default: map-get($colors, white), - hover: map-get($colors, silver) - ), - secondary: ( - default: map-get($colors, white-smoke), - hover: map-get($colors, gainsboro) - ) -); - From f177eda5fbbcacf970aebcf6dd8137c32a12395c Mon Sep 17 00:00:00 2001 From: Adam Marcinkowski Date: Sun, 25 Feb 2018 17:39:49 +0100 Subject: [PATCH 03/15] [#639] Refactore border colors --- .../default/components/core/ColorButton.vue | 4 ++-- .../default/components/core/NewsletterPopup.vue | 2 +- .../default/components/core/PriceButton.vue | 2 +- .../default/components/core/ProductLinks.vue | 2 +- .../default/components/core/SizeButton.vue | 2 +- .../components/core/blocks/Auth/ForgotPass.vue | 2 +- .../components/core/blocks/Auth/Login.vue | 4 ++-- .../components/core/blocks/Auth/Register.vue | 10 +++++----- .../core/blocks/Checkout/CartSummary.vue | 2 +- .../core/blocks/Checkout/PersonalDetails.vue | 10 +++++----- .../components/core/blocks/Footer/Footer.vue | 4 ++-- .../components/core/blocks/Header/Header.vue | 2 +- .../core/blocks/MyAccount/MyProfile.vue | 6 +++--- .../core/blocks/SearchPanel/SearchPanel.vue | 2 +- .../core/blocks/SidebarMenu/SidebarMenu.vue | 16 ++++++++-------- .../core/blocks/SidebarMenu/SubCategory.vue | 6 +++--- src/themes/default/pages/Compare.vue | 4 ++-- 17 files changed, 40 insertions(+), 40 deletions(-) diff --git a/src/themes/default/components/core/ColorButton.vue b/src/themes/default/components/core/ColorButton.vue index 38e7bbcf98..3a067e52d4 100644 --- a/src/themes/default/components/core/ColorButton.vue +++ b/src/themes/default/components/core/ColorButton.vue @@ -1,12 +1,12 @@