Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VDataTable): Loading Progress bar pushes content down #10169

Merged
merged 9 commits into from Feb 18, 2020
Merged

fix(VDataTable): Loading Progress bar pushes content down #10169

merged 9 commits into from Feb 18, 2020

Conversation

Aramis13
Copy link
Contributor

@Aramis13 Aramis13 commented Jan 9, 2020

Description

Added absolute property to v-data-table__progress.

Motivation and Context

Fixes issue #9668.

How Has This Been Tested?

Locally in playground.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • [x ] The PR title is no longer than 64 characters.
  • [ x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • [x ] My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@johnleider johnleider added C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected labels Jan 10, 2020
@johnleider
Copy link
Member

This is what I'm seeing:

image

@jacekkarczmarczyk
Copy link
Member

oh right, i'm using .v-data-table { positon: relative } in my apps, but probably it should be applied to progress container instead of the whole table

johnleider
johnleider previously requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues with overflow that need to be resolved.

@KaelWD KaelWD force-pushed the master branch 3 times, most recently from 9e00958 to de967ac Compare February 5, 2020 07:33
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.2.x milestone Feb 18, 2020
@MajesticPotatoe MajesticPotatoe merged commit 6bb6238 into vuetifyjs:master Feb 18, 2020
@jacekkarczmarczyk jacekkarczmarczyk mentioned this pull request Feb 18, 2020
Closed
Logikgate pushed a commit to flypapertech/vuetify that referenced this pull request Feb 19, 2020
@Aramis13 @nekosaur
@MajesticPotatoe @Logikgate
fix(VDataTable): Loading Progress bar pushes content down (vuetifyjs#…
3e78f1d 
…10169)

* Revert to non locale sensitive number sort

* [Bug Fix]Loading Progress bar pushes content down

* Fix overflow issues

Co-authored-by: Albert Kaaman <albert@kaaman.nu>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
whoistobias pushed a commit to whoistobias/vuetify that referenced this pull request Feb 26, 2020
@Aramis13 @nekosaur
@MajesticPotatoe @whoistobias
fix(VDataTable): Loading Progress bar pushes content down (vuetifyjs#…
8cca0ec 
…10169)

* Revert to non locale sensitive number sort

* [Bug Fix]Loading Progress bar pushes content down

* Fix overflow issues

Co-authored-by: Albert Kaaman <albert@kaaman.nu>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
This was referenced Mar 12, 2020
Closed
Closed
Closed
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nekosaur nekosaur nekosaur approved these changes

@johnleider johnleider johnleider left review comments

Assignees
No one assigned
Labels
C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.2.x
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Aramis13 @johnleider @jacekkarczmarczyk @nekosaur @MajesticPotatoe