Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.0.0-beta.8] VOverlay should not block scroll by default when contained #15653

Closed
SkyaTura opened this issue Aug 18, 2022 · 9 comments
Assignees
Labels
C: VOverlay VOverlay T: enhancement Functionality that enhances existing features
Milestone

Comments

@SkyaTura
Copy link
Contributor

Environment

Vuetify Version: 3.0.0-beta.8
Vue Version: 3.2.37
Browsers: Chrome 102.0.5005.167
OS: Mac OS 10.15.7

Steps to reproduce

In a big and scrollable page, create a card with a contained overlay with v-hover, just like in the documented example, then, try to scroll normally then hover the card and try to scroll again.

Expected Behavior

If the overlay is contained, it is expected that it won't block scrolling.

Actual Behavior

The scroll strategy always defaults block no matter what.

Reproduction Link

https://codesandbox.io/s/vuetify-voverlay-scroll-unexpected-behavior-v62289?file=/src/App.vue

@SkyaTura SkyaTura changed the title [Bug Report][3.0.0-beta.8] VOverlay should not block scroll when contained [Bug Report][3.0.0-beta.8] VOverlay should not block scroll by default when contained Aug 18, 2022
@SkyaTura
Copy link
Contributor Author

I've updated the reproduction link because apparently I forgot to save the final version of the file...

@nekosaur
Copy link
Member

Use scroll-strategy="none"

@SkyaTura
Copy link
Contributor Author

SkyaTura commented Aug 24, 2022

@nekosaur
Use scroll-strategy="none"

That works, but I think it should be default when contained is applied.

It seems counterintuitive for me that an overlay in a card would lock the entire screen if I don't explicit say so.

Or at least warn in the docs to the developers know they should be concerned with this property when dealing with contained overlays.

@KaelWD
Copy link
Member

KaelWD commented Aug 25, 2022

The default scroll-strategy should probably just be changed to none globally.

@KaelWD KaelWD added T: enhancement Functionality that enhances existing features C: VOverlay VOverlay and removed S: triage labels Aug 25, 2022
@KaelWD KaelWD added this to the v3.0.0-beta milestone Aug 25, 2022
@KaelWD KaelWD self-assigned this Aug 25, 2022
@Antti-Palola
Copy link
Contributor

Antti-Palola commented Aug 27, 2022

Is this more of a new ticket but feels related..? Should the overlay really block scrolling of every ancestor when contained and scrollStrategy is block?
When overlay is contained shouldn't the getScrollParents stop at first found scrollparent?

@SkyaTura

This comment was marked as off-topic.

@KaelWD
Copy link
Member

KaelWD commented Aug 29, 2022

Stopping at the first found parent would still be the window in that example

@furkancanzirek
Copy link

Use scroll-strategy="none"

that's worked for me thank you.

@balaji-ksk
Copy link

Use scroll-strategy="none"

that's worked for me thank you.

That is also work for me. Use this on V-overlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VOverlay VOverlay T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

6 participants