Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Possible error on expandable and searchable data tables #3050

Closed
ghost opened this issue Jan 19, 2018 · 1 comment · Fixed by #3852
Closed

[Bug Report] Possible error on expandable and searchable data tables #3050

ghost opened this issue Jan 19, 2018 · 1 comment · Fixed by #3852
Assignees
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@ghost
Copy link

ghost commented Jan 19, 2018

Versions and Environment

Vuetify: 0.17.6
Vue: 2.5.13
Browsers: Chrome 63.0.3239.132
OS: Windows 7

Steps to reproduce

1.- Create a data table that is expandable, and searchable as well, with some items.
2.- Expand one of the last items from the table.
3.- Search for that item on the text field (it should show you that item on the table expanded).
4.- Clear the search term from the textfield (now it shows all items with the expanded item still expanded).
5.- Close the expanded item.

Expected Behavior

Item closes correctly with no errors.

Actual Behavior

Item does close the expanded panel but throws and error on the console: "TypeError: Cannot read property 'classList' of undefined at afterLeave"

Reproduction Link

https://codepen.io/dn1993/pen/baOQVo

Other comments

The error can be triggered on the pen I attached here with the third and fourth items from the table. I tried to override the genExpandedRow function on the VDataTable mixins (body.js) to add a try catch block but I still get the error. This framework is truly awesome, keep up the great work!

@nekosaur nekosaur added the pending review The issue is still pending disposition label Jan 20, 2018
@kaijajan
Copy link

I encountered exactly the same issue while combining search and expand features.
Error occurs right after manipulate expand feature after searching keyword

@nekosaur nekosaur self-assigned this Mar 8, 2018
@nekosaur nekosaur added T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition labels Mar 8, 2018
@nekosaur nekosaur added this to the v1.2.x milestone Apr 13, 2018
nekosaur added a commit that referenced this issue Apr 14, 2018
expand-transition generated error if it started expanded, as el._parent was not set

closes #3812, closes #3050
@KaelWD KaelWD modified the milestones: v1.2.x, v1.0.x Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants