Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spanish locale #5359

Merged
merged 5 commits into from Nov 18, 2018
Merged

feat: add spanish locale #5359

merged 5 commits into from Nov 18, 2018

Conversation

jblancogl
Copy link
Contributor

Added spanish translation.

Description

Added spanish translation.

Motivation and Context

Supporting a new language.

How Has This Been Tested?

It is not tested since it is a translation file.

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@KaelWD KaelWD added the S: has merge conflicts The pending Pull Request has merge conflicts label Oct 29, 2018
@naulacambra
Copy link

Which conflicts are blocking this PR?

@jacekkarczmarczyk
Copy link
Member

files has been moved from /src/locale to /packages/vuetify/src/locale

@KaelWD KaelWD removed the S: has merge conflicts The pending Pull Request has merge conflicts label Nov 10, 2018
KaelWD
KaelWD previously approved these changes Nov 10, 2018
@KaelWD KaelWD added this to the v1.4.0 milestone Nov 10, 2018
@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #5359 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5359      +/-   ##
==========================================
+ Coverage   89.72%   89.75%   +0.03%     
==========================================
  Files         267      268       +1     
  Lines        5928     5907      -21     
  Branches     1476     1464      -12     
==========================================
- Hits         5319     5302      -17     
+ Misses        488      481       -7     
- Partials      121      124       +3
Impacted Files Coverage Δ
packages/vuetify/src/locale/es.ts 100% <100%> (ø)
packages/vuetify/src/locale/index.ts 100% <100%> (ø) ⬆️
...fy/src/components/transitions/expand-transition.js 47.82% <0%> (-2.18%) ⬇️
...s/vuetify/src/components/VDataTable/mixins/body.js 70.37% <0%> (-1.06%) ⬇️
packages/vuetify/src/components/VSelect/VSelect.js 88.26% <0%> (-0.17%) ⬇️
packages/vuetify/src/mixins/menuable.js 95.09% <0%> (-0.1%) ⬇️
.../vuetify/src/components/VDatePicker/VDatePicker.js 92.06% <0%> (-0.07%) ⬇️
.../vuetify/src/components/VTreeview/VTreeviewNode.ts 97.18% <0%> (-0.04%) ⬇️
...es/vuetify/src/components/VTextField/VTextField.js 95.9% <0%> (ø) ⬆️
...rc/components/VDatePicker/VDatePickerMonthTable.js 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5591e8...9a76b48. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk mentioned this pull request Nov 15, 2018
8 tasks
@KaelWD KaelWD merged commit dd3f7c8 into vuetifyjs:dev Nov 18, 2018
SeanLMcCullough pushed a commit to SeanLMcCullough/vuetify that referenced this pull request Nov 29, 2018
* feat: add spanish locale

* fix: move file to correct location

* feat: add entry to locale index
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants