Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] aria roles for VList / VListTile #5667

Closed
jacekkarczmarczyk opened this issue Nov 20, 2018 · 1 comment
Closed

[Feature Request] aria roles for VList / VListTile #5667

jacekkarczmarczyk opened this issue Nov 20, 2018 · 1 comment
Labels
good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features

Comments

@jacekkarczmarczyk
Copy link
Member

Problem to solve

VList/VListTile use divs instead of ol/ul/li so they are missing aria roles

Proposed solution

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/List_role
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Listitem_role
@jacekkarczmarczyk jacekkarczmarczyk added T: enhancement Functionality that enhances existing features good first issue A quick-win fix that would be great for new contributors labels Nov 20, 2018
jacekkarczmarczyk added a commit that referenced this issue Nov 20, 2018
@jacekkarczmarczyk
feat: aria roles for VList and VListTile
4d3adec 
fixes #5667
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Nov 20, 2018
Merged
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Nov 20, 2018
@plweil
Copy link

plweil commented Nov 21, 2018

If these are lists, why not just use the html elements with the appropriate native semantics instead of adding aria roles?

First Rule of ARIA Use: If you can use a native HTML element [ HTML51 ] or attribute with the semantics and behavior you require already built in, instead of re-purposing an element and adding an ARIA role, state or property to make it accessible, then do so.

SeanLMcCullough pushed a commit to SeanLMcCullough/vuetify that referenced this issue Nov 29, 2018
@jacekkarczmarczyk
feat(List): improve aria support (vuetifyjs#5671)
0e9d153 
* feat: aria roles for VList and VListTile

fixes vuetifyjs#5667

* removed code that shouldnt be there
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plweil @jacekkarczmarczyk