Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VBanner): add new component #6520

Merged
merged 23 commits into from Feb 24, 2019
Merged

feat(VBanner): add new component #6520

merged 23 commits into from Feb 24, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Feb 16, 2019

Description

Add VBanner component matching md2 spec

Motivation and Context

Fixes #6068

How Has This Been Tested?

kitchen => Banners, jest

Markup:

kitchen => Banners

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@dsseng dsseng added T: feature A new feature S: needs docs update The change requires an update to the documentation md2 The issue pertains to Material Spec 2 S: work in progress S: needs unit tests This PR needs unit tests labels Feb 16, 2019
@dsseng dsseng added this to the v2.0.0 milestone Feb 16, 2019
@dsseng dsseng self-assigned this Feb 16, 2019
@TravisBuddy
Copy link

TravisBuddy commented Feb 16, 2019

Hey @sh7dm,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3dbf9760-3856-11e9-b76d-d9638afbe879

@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #6520 into next will decrease coverage by 0.21%.
The diff coverage is 35.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #6520      +/-   ##
=========================================
- Coverage   89.02%   88.8%   -0.22%     
=========================================
  Files         309     311       +2     
  Lines        7554    7585      +31     
  Branches     1869    1874       +5     
=========================================
+ Hits         6725    6736      +11     
- Misses        729     749      +20     
  Partials      100     100
Impacted Files Coverage Δ
packages/vuetify/src/components/index.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VBanner/index.ts 100% <100%> (ø)
packages/vuetify/src/components/VBanner/VBanner.ts 25.92% <25.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ddddf...dde02a1. Read the comment docs.

Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! One more thing except mentioned dismiss action i think would be nice - possibility to create a banner with paddings:

https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F1dc4XW_5Ztd7xNixB4lFtnodPXi-Fl5yJ%2Fbanners-placement-desktop-lightbox.png

Maybe we could use the mechanism similiar like in v-container? Fluid would be full width, not fluid would have padding. Or maybe wide prop?

Also:

Banners in wide layouts span the entire width of the screen. They appear at the same elevation as the top app bar and remain on screen while content scrolls.

Maybe fixed prop? If yes, then probably it should taken into account in applicationable or goTo

packages/vuetify/src/components/VBanner/VBanner.sass Outdated Show resolved Hide resolved
packages/vuetify/src/components/VBanner/VBanner.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging February 16, 2019 17:15 Inactive
@dsseng dsseng added the S: on hold The issue is on hold until further notice label Feb 18, 2019
remove transitionable mixin
root element cannot have padding. restructured structure/styles to acommodate
@vercel vercel bot temporarily deployed to staging February 18, 2019 19:58 Inactive
@johnleider johnleider merged commit 043fff0 into next Feb 24, 2019
@johnleider johnleider deleted the feat/banners branch February 24, 2019 16:58
@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #6520 into next will increase coverage by 0.05%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #6520      +/-   ##
=========================================
+ Coverage   83.25%   83.3%   +0.05%     
=========================================
  Files         316     318       +2     
  Lines        7845    7881      +36     
  Branches     1937    1944       +7     
=========================================
+ Hits         6531    6565      +34     
- Misses       1210    1212       +2     
  Partials      104     104
Impacted Files Coverage Δ
packages/vuetify/src/components/index.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VBanner/index.ts 100% <100%> (ø)
packages/vuetify/src/components/VBanner/VBanner.ts 93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c9a9d...a15a726. Read the comment docs.

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
md2 The issue pertains to Material Spec 2 T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants