New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VBanner): add new component #6520
Conversation
Hey @sh7dm, TravisBuddy Request Identifier: 3dbf9760-3856-11e9-b76d-d9638afbe879 |
Codecov Report
@@ Coverage Diff @@
## next #6520 +/- ##
=========================================
- Coverage 89.02% 88.8% -0.22%
=========================================
Files 309 311 +2
Lines 7554 7585 +31
Branches 1869 1874 +5
=========================================
+ Hits 6725 6736 +11
- Misses 729 749 +20
Partials 100 100
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! One more thing except mentioned dismiss action i think would be nice - possibility to create a banner with paddings:
Maybe we could use the mechanism similiar like in v-container? Fluid would be full width, not fluid would have padding. Or maybe wide
prop?
Also:
Banners in wide layouts span the entire width of the screen. They appear at the same elevation as the top app bar and remain on screen while content scrolls.
Maybe fixed
prop? If yes, then probably it should taken into account in applicationable or goTo
remove transitionable mixin
root element cannot have padding. restructured structure/styles to acommodate
Codecov Report
@@ Coverage Diff @@
## next #6520 +/- ##
=========================================
+ Coverage 83.25% 83.3% +0.05%
=========================================
Files 316 318 +2
Lines 7845 7881 +36
Branches 1937 1944 +7
=========================================
+ Hits 6531 6565 +34
- Misses 1210 1212 +2
Partials 104 104
Continue to review full report at Codecov.
|
Description
Add
VBanner
component matching md2 specMotivation and Context
Fixes #6068
How Has This Been Tested?
kitchen => Banners,
jest
Markup:
kitchen => Banners
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).