Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct `BootstrapVue` name and stats #10580

Open
wants to merge 1 commit into
base: master
from

Conversation

@jackmu95
Copy link

jackmu95 commented Feb 14, 2020

Description

Hi 馃憢, @jackmu95 from BootstrapVue here.

This PR corrects our name and stats in the "Vue Framework Comparison".

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
@johnleider

This comment has been minimized.

Copy link
Member

johnleider commented Feb 14, 2020

I鈥檓 removing component count as a metric because it鈥檚 pointless. With that being said, what did you use to determine component count?

@jackmu95

This comment has been minimized.

Copy link
Author

jackmu95 commented Feb 14, 2020

I鈥檓 removing component count as a metric because it鈥檚 pointless

+1 for that

With that being said, what did you use to determine component count?

Being honest, I just trusted what @tmorehouse updated our repo description to.

But I've looked further into it and we have 98 individual component exports in:
https://github.com/bootstrap-vue/bootstrap-vue/blob/dev/src/index.js

This is including sub-components but not component aliases and directives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.