Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert v-avatar to typescript #4538

Merged
merged 2 commits into from Jul 9, 2018

Conversation

Projects
None yet
5 participants
@jacekkarczmarczyk
Copy link
Contributor

jacekkarczmarczyk commented Jul 9, 2018

How Has This Been Tested?

manually

Markup:

<template>
  <v-app dark>
    <v-content>
      <v-container>
        <v-layout align-center justify-space-around wrap>
          <v-avatar color="indigo">
            <v-icon dark>account_circle</v-icon>
          </v-avatar>

          <v-avatar>
            <img src="https://cdn.vuetifyjs.com/images/john.jpg" alt="John">
          </v-avatar>

          <v-badge overlap>
            <span slot="badge">3</span>
            <v-avatar color="purple red--after">
              <v-icon dark>notifications</v-icon>
            </v-avatar>
          </v-badge>

          <v-avatar color="teal">
            <span class="white--text headline">C</span>
          </v-avatar>

          <v-avatar color="red">
            <span class="white--text headline">J</span>
          </v-avatar>
        </v-layout>
      </v-container>
    </v-content>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #4538 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4538      +/-   ##
=========================================
+ Coverage   89.53%   89.7%   +0.17%     
=========================================
  Files         206     207       +1     
  Lines        4884    4956      +72     
  Branches     1236    1255      +19     
=========================================
+ Hits         4373    4446      +73     
+ Misses        411     410       -1     
  Partials      100     100
Impacted Files Coverage Δ
src/components/VAvatar/index.ts 100% <ø> (ø)
src/components/VAvatar/VAvatar.ts 100% <100%> (ø)
src/components/VApp/VApp.js 100% <0%> (ø) ⬆️
src/components/Vuetify/index.ts 100% <0%> (ø) ⬆️
src/components/VApp/mixins/app-breakpoint.js 100% <0%> (ø)
src/components/VToolbar/VToolbar.js 96.72% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4453c...ace0e26. Read the comment docs.

@KaelWD

KaelWD approved these changes Jul 9, 2018

@KaelWD KaelWD changed the title chore(v-avatar): converted to typescript refactor: convert v-avatar to typescript Jul 9, 2018

@KaelWD KaelWD merged commit bb7a35f into master Jul 9, 2018

5 checks passed

codebeat Target branch is not tracked
Details
codecov/patch 100% of diff hit (target 89.53%)
Details
codecov/project 89.7% (+0.17%) compared to 8d4453c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jacekkarczmarczyk jacekkarczmarczyk deleted the chore/v-avatar-typescript branch Jul 9, 2018

@iabdulin

This comment has been minimized.

Copy link

iabdulin commented Oct 17, 2018

The 200 millionth pull request!
https://octoverse.github.com/projects

image

@ajax900

This comment was marked as off-topic.

Copy link

ajax900 commented Nov 7, 2018

pull this request

@vuchan

This comment was marked as off-topic.

Copy link

vuchan commented Nov 21, 2018

pull this request one more.

@vuetifyjs vuetifyjs locked as off topic and limited conversation to collaborators Nov 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.