time picker bugfix for empty string

[GPlay97]

Description

I have enhanced the check on setInputData to also validate for empty strings instead of only null values.

Motivation and Context

Otherwise, if empty string provided as value, it produces NaN:NaN

How Has This Been Tested?

Changed the line, tested it - it fixed the issues. Now it will be treated as null value (--:--)

Markup:

<template>
  <div>
    <v-checkbox v-model="landscape" label="Landscape"></v-checkbox>
    <v-time-picker v-model="picker" :landscape="landscape"></v-time-picker>
  </div>
</template>
<script>
  export default {
    data () {
      return {
        picker: '',
        landscape: false
      }
    }
  }
</script>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have created a PR in the documentation with the necessary changes.

[codecov]

Codecov Report

Merging #5218 into master will increase coverage by 0.62%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5218      +/-   ##
==========================================
+ Coverage   89.09%   89.72%   +0.62%     
==========================================
  Files         230      246      +16     
  Lines        5466     5830     +364     
  Branches     1373     1455      +82     
==========================================
+ Hits         4870     5231     +361     
  Misses        476      476              
- Partials      120      123       +3

Impacted Files	Coverage Δ
src/components/VTimePicker/VTimePicker.js	95.71% <100%> (ø)	⬆️
src/components/VTabs/mixins/tabs-watchers.js	84.61% <0%> (-15.39%)	⬇️
src/mixins/themeable.ts	91.3% <0%> (-8.7%)	⬇️
src/directives/ripple.ts	34.51% <0%> (-7.54%)	⬇️
src/components/VBtn/VBtn.ts	96.87% <0%> (-3.13%)	⬇️
src/components/VTabs/VTab.js	96.42% <0%> (-0.45%)	⬇️
src/components/VStepper/VStepperStep.js	67.85% <0%> (-0.15%)	⬇️
src/components/VAutocomplete/VAutocomplete.js	98.16% <0%> (-0.07%)	⬇️
src/util/ThemeProvider.ts	100% <0%> (ø)	⬆️
src/mixins/routable.ts	100% <0%> (ø)	⬆️
... and 58 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d343c...f85496d. Read the comment docs.

[jacekkarczmarczyk]

Please add unit test

diff --git a/test/unit/components/VTimePicker/VTimePicker.spec.js b/test/unit/components/VTimePicker/VTimePicker.spec.js
index 01657e36..72c1c31d 100644
--- a/test/unit/components/VTimePicker/VTimePicker.spec.js
+++ b/test/unit/components/VTimePicker/VTimePicker.spec.js
@@ -183,6 +183,10 @@ test('VTimePicker.js', ({ mount }) => {
     expect(wrapper.vm.inputHour).toBe(null)
     expect(wrapper.vm.inputMinute).toBe(null)

+    wrapper.vm.setInputData('')
+    expect(wrapper.vm.inputHour).toBe(null)
+    expect(wrapper.vm.inputMinute).toBe(null)
+
     wrapper.vm.setInputData('12:34am')
     expect(wrapper.vm.inputHour).toBe(0)
     expect(wrapper.vm.inputMinute).toBe(34)

[GPlay97]

I have added them :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord