fix(useScroll): types for ref include null and undefined #828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
With Vue composition API the ref is null or undefined intially. There is a type error as these are not accepted
Example
Error:
Argument of type 'Ref<HTMLElement | null>' is not assignable to parameter of type 'MaybeRef<Window | HTMLElement | Document | SVGElement>'.
Fix:
Add null and undefined as accepted types, just like with useScroll() and other vueuse functions