Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTransition): call pause() to stop useRafFn when disabling #2360

merged 5 commits into from Nov 9, 2022


Copy link

@huodoushigemi huodoushigemi commented Oct 24, 2022


Set disabled to true during animation, and the program performs normally,
However, the internal useRafFn is still running, which is unnecessary.

So I called pause() when disabled

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@huodoushigemi huodoushigemi changed the title fix(useTransition): 禁用状态调用 pause() 停止 useRafFn fix(useTransition): call pause() to stop useRafFn when disabling Oct 25, 2022
@antfu antfu enabled auto-merge (squash) November 9, 2022 00:04
@antfu antfu merged commit 0a49ea4 into vueuse:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants